848395 - GC: Move Rooted to JS namespace

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: 1 - Move js::Rooted to JS namespace

Comment 2

[Jon Coppeard (:jonco)]

Attachment: 2 - Rename references to js::Rooted to JS::Rooted inside Spidermonkey

Comment 3

[Jon Coppeard (:jonco)]

Attachment: 3 - Rename references to js::Rooted to JS::Rooted outside Spidermonkey

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 721745 [details] [diff] [review]
2 - Rename references to js::Rooted to JS::Rooted inside Spidermonkey

Review of attachment 721745 [details] [diff] [review]:
-----------------------------------------------------------------

I had forgotten about jsapi-tests: it was not exactly rooted when I made the previous namespace move.

::: js/src/jsclone.h
@@ +90,5 @@
>      uint64_t *point;
>      uint64_t *end;
>  };
>  
> +} /* namespace js */

Nice!

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 721746 [details] [diff] [review]
3 - Rename references to js::Rooted to JS::Rooted outside Spidermonkey

Review of attachment 721746 [details] [diff] [review]:
-----------------------------------------------------------------

I see browser usage has grown considerably.

Comment 6

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f27dbd9ba370
https://hg.mozilla.org/integration/mozilla-inbound/rev/e112b04664a6
https://hg.mozilla.org/integration/mozilla-inbound/rev/28ef4bdff455

Comment 7

[Ed Morley [:emorley]]

Push backed out for Window mochitest-chrome crashes:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1768185637fd

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=7f0a4a8f2013

Comment 8

[Jon Coppeard (:jonco)]

Relanding:

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc80038cf2ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9dca222d6c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d3f5942d825

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc80038cf2ef
https://hg.mozilla.org/mozilla-central/rev/e9dca222d6c3
https://hg.mozilla.org/mozilla-central/rev/0d3f5942d825