Closed Bug 848395 Opened 7 years ago Closed 7 years ago

GC: Move Rooted to JS namespace

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(3 files)

No description provided.
Attachment #721744 - Flags: review?(terrence)
Attachment #721744 - Flags: review?(terrence) → review+
Comment on attachment 721745 [details] [diff] [review]
2 - Rename references to js::Rooted to JS::Rooted inside Spidermonkey

Review of attachment 721745 [details] [diff] [review]:
-----------------------------------------------------------------

I had forgotten about jsapi-tests: it was not exactly rooted when I made the previous namespace move.

::: js/src/jsclone.h
@@ +90,5 @@
>      uint64_t *point;
>      uint64_t *end;
>  };
>  
> +} /* namespace js */

Nice!
Attachment #721745 - Flags: review?(terrence) → review+
Comment on attachment 721746 [details] [diff] [review]
3 - Rename references to js::Rooted to JS::Rooted outside Spidermonkey

Review of attachment 721746 [details] [diff] [review]:
-----------------------------------------------------------------

I see browser usage has grown considerably.
Attachment #721746 - Flags: review?(terrence) → review+
You need to log in before you can comment on or make changes to this bug.