Closed Bug 848409 Opened 11 years ago Closed 11 years ago

Only enable Strict Mode logging for developers' local builds (to avoid flooding Socorro crash logs)

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox19 wontfix, firefox20 wontfix, firefox21 fixed, firefox22 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 22
Tracking Flags:
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
firefox22 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(2 files)

part-1-disable-strict-mode.patch
4.06 KB, patch
kats
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
part-2-remove-unused-defaults-xml.patch
5.74 KB, patch
kats
: review+
Details | Diff | Splinter Review 
      No description provided.
Attachment #721754 - Flags: review?(bugmail.mozilla)
Part 2: Remove unused mobile/android/branding/[nightly|aurora|beta|release]/res/values/defaults.xml resource files.

These defaults.xml resource files no longer contain any settings. dougt insisted I create these resource files when I added the code to enable Strict Mode logging, but no other feature has leveraged these files since then. :)
Attachment #721758 - Flags: review?(bugmail.mozilla)
Attachment #721754 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 721758 [details] [diff] [review]
part-2-remove-unused-defaults-xml.patch

Review of attachment 721758 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming this works as expected. I didn't realize this boolean was so heavy on the build!
Attachment #721758 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 721754 [details] [diff] [review]
part-1-disable-strict-mode.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 708114
User impact if declined: None.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk. This patch does not fix a bug, but it will make the Android crash logs we collect for Socorro crash reports more useful (by removing some log messages that are flooding our crash logs).
String or UUID changes made by this patch: N/A
Attachment #721754 - Flags: approval-mozilla-aurora?
Attachment #721754 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: