848490 - [SkiaGL] Handle canvas elements larger than the maximum GPU texture size

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[George Wright (:gw280) (needinfo me!)]

On mobile, 4096x4096 is common as the maximum texture size. A bunch of canvas demos use textures larger than this as atlases. We should investigate either implementing a tiled render target architecture (long-term solution) and a software fallback if the canvas dimensions exceed the maximum GPU allowable dimensions (short term).

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: fallback to software

Fallback to software if GLContextProvider::CreateOffscreen returns nullptr (which it should do if we try to create an offscreen larger than the GPU can handle).

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 743813 [details] [diff] [review]
fallback to software

Review of attachment 743813 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, I had the exact same patch locally. Looks good.

Comment 3

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/mozilla-central/rev/f2d0107e85ec

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for reftest crashes. Thanks for watching your push after landing on m-c, btw.
https://hg.mozilla.org/mozilla-central/rev/b25afb305360

https://tbpl.mozilla.org/php/getParsedLog.php?id=22711192&tree=Mozilla-Central

Comment 5

[Ryan VanderMeulen [:RyanVM]]

And a mochitest failure.
https://tbpl.mozilla.org/php/getParsedLog.php?id=22711902&tree=Mozilla-Central

And a reftest unexpected pass.
https://tbpl.mozilla.org/php/getParsedLog.php?id=22711772&tree=Mozilla-Central

Comment 6

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/715da6d0a786

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/715da6d0a786