848535 - (CVE-2013-1694) Use of PreserveWrapper in cases when we don't have a wrapper seems broken

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Consider the following scenario:

1)  XHR starts.
2)  Its wrapper, if any, is collected.
3)  A C++ readystatechange listener calls GetResponse, and the response type is
    JSON or arraybuffer.  This causes nsXMLHttpRequest::RootJSResultObjects to be
    called, which calls PreserveWrapper.
4)  JS touches the XHR object, causing it to be wrapped, which calls
    nsWrapperCache::SetWrapper().

In a debug build this will assert fatally. In an opt build this will clear the preserved-wrapper flag on the wrapper cache, which seems bad.

Should we just preserve that flag on SetWrapper and remove the assert in that method, perhaps?  Alternately, we should stop using PreserveWrapper to mean "hold JS objects" in XHR.

Note that the above scenario is pretty simple to produce with a worker XHR if extension JS can ever touch the main-thread nsXMLHttpRequest of it, as far as I can tell.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

nsDOMFileReader is possibly similarly broken.

Comment 2

[Andrew McCreight [:mccr8]]

Sounds kind of bad.  Feel free to adjust as needed.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

May not get to this before next week.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This should do it. Technically drop in unlink isn't absolutely needed, but
we do drop preserved wrapper there too if there is such (in nsDOMEventTargetHelper). These aren't super perf critical so extra drop isn't too bad.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

But then, drop in unlink is rather useless... I'll remove it

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 746648 [details] [diff] [review]
patch

[Security approval request comment]
How easily could an exploit be constructed based on the patch?
As of now we don't know any exploit, but I don't think constructing one is too difficult.

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?
commit will be about simpler js object holding

Which older supported branches are affected by this flaw?
all

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?
backports should be almost the same

How likely is this patch to cause regressions; how much testing does it need?
Should be relatively safe

Comment 8

[Al Billings [:abillings - ex-MoCo]]

sec-approval+ for m-c on 5/14 after we branch and ship. Please prepare and nominate branch patches as well.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21356b1fc017

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21356b1fc017

Comment 11

[Alex Keybl [:akeybl]]

Ready for uplift noms?

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Preparing patches ....

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Attachment: for branches

This patch seems to apply to branches. esr17 needs --fuzz=4


[Approval Request Comment]
Bug caused by (feature/regressing bug #): Something ancient
User impact if declined: Possible GC/CC related crashes
Testing completed (on m-c, etc.): landed to m-c 2013-05-15
Risk to taking this patch (and alternatives if risky): Shouldn't be risky
String or IDL/UUID changes made by this patch: NA

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 752297 [details] [diff] [review]
for branches

approving for desktop branches, holding off on b2g18 until we know if this needs to be uplifted to v1.0.1 - since it's only sec-high, I suspect it does not but will wait for confirmation.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c43520eb66d0
https://hg.mozilla.org/releases/mozilla-beta/rev/6c0015af8603
https://hg.mozilla.org/releases/mozilla-esr17/rev/7298d758e1fa

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/8d224b154448

Comment 17

[Matt Wobensmith [:mwobensmith][:matt:]]

Based on the steps in comment 0 and the lack of an existing test case, we're going to mark this qa- for verification purposes. If that changes, remove qa- and/or let us know how we could otherwise verify fixed. Thanks.