Closed
Bug 848576
Opened 12 years ago
Closed 12 years ago
Remove scripts and newScript packets from the RDP
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 2 obsolete files)
21.76 KB,
patch
|
past
:
checkin+
|
Details | Diff | Splinter Review |
Panos recently mentioned (bug 785704 comment 17) that he thinks we should remove these packets. It would make my work in bug 772119 easier as well. Best not to have extra technical debt that we don't need.
However, this involves reworking our backwards compat tests.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #722442 -
Flags: review?(past)
Comment 2•12 years ago
|
||
Comment on attachment 722442 [details] [diff] [review]
v1
Review of attachment 722442 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/devtools/debugger/dbg-client.jsm
@@ +695,5 @@
>
> SSProto.name = "sources";
>
> SSProto.onPacketTest = function SS_onPacketTest(aPacket) {
> + dump();
Ditch the dump() calls in this file.
::: toolkit/devtools/debugger/server/dbg-script-actors.js
@@ +662,5 @@
> onSources: function TA_onSources(aRequest) {
> this._discoverScriptsAndSources();
> let urls = Object.getOwnPropertyNames(this._sources);
> return {
> sources: [this._getSource(url).form() for (url of urls)]
Perhaps you can now inline _getSource?
::: toolkit/devtools/debugger/tests/unit/test_sources_backwards_compat-01.js
@@ +39,5 @@
> }
>
> function test_new_source_compatibility()
> {
> + dump("FITZGEN: inside test_new_source_compatibility\n");
Moar dump()s!
::: toolkit/devtools/debugger/tests/unit/testcompatactors.js
@@ +42,5 @@
> + let script = {
> + url: url,
> + startLine: i,
> + lineCount: this._scripts[url][i].lineCount,
> + source: this._getSource(url).form()
Ah, so you are still using _getSource here.
Attachment #722442 -
Flags: review?(past) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Ame as v1, but without the dump logs.
Sorry, Panos! I need to make a checklist (or better yet a script) for all these little things. In fact, I think I need a whole suite of mozilla specific commands...
Ask JimB about checklists sometime, he has a great article to share :)
Attachment #722442 -
Attachment is obsolete: true
Attachment #722874 -
Flags: checkin?(past)
Assignee | ||
Comment 4•12 years ago
|
||
Rebasing on fx-team
Attachment #722874 -
Attachment is obsolete: true
Attachment #722874 -
Flags: checkin?(past)
Attachment #723667 -
Flags: checkin?(past)
Comment 5•12 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
Updated•12 years ago
|
Attachment #723667 -
Flags: checkin?(past) → checkin+
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•