848581 - Enable cubeb by default on gonk

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Michael Wu [:mwu]]

Attachment: Enable cubeb by default on gonk

Once bug 839007 is fixed, we can finally switch to the cubeb backend on gonk.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 721922 [details] [diff] [review]
Enable cubeb by default on gonk

mchen, do you think the cubeb backend is ready? Or are there other things that need to be fixed before we enable this?

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 721922 [details] [diff] [review]
Enable cubeb by default on gonk

Sounds good to me.

Comment 3

[Marco Chen [:mchen]]

Comment on attachment 721922 [details] [diff] [review]
Enable cubeb by default on gonk

Review of attachment 721922 [details] [diff] [review]:
-----------------------------------------------------------------

I tried to do some testing and there is no obvious error or crash.
so I think it can be enabled after fixing the known crash issue.

Comment 4

[Matthew Gregan [:kinetik]]

We need also need bug 839415 landed before we can land this.

Comment 5

[Marco Chen [:mchen]]

Hi Matthew & Michael,

May I know that libcubeb will be planed to enable on V1.X?
At least bug 842195 waits for this.

Thanks.

Comment 6

[Michael Wu [:mwu]]

(In reply to Marco Chen [:mchen] from comment #5)
> Hi Matthew & Michael,
> 
> May I know that libcubeb will be planed to enable on V1.X?
> At least bug 842195 waits for this.
> 
> Thanks.

Feel free to check this patch in right now if you want.

Comment 7

[Michael Wu [:mwu]]

Oh I misread your comment.

I was expecting this to be for v2.0. If you need cubeb on v1.1, we'll need approval to land all the patches to support this. We need to enable this on trunk first, at any rate.

Comment 8

[Matthew Gregan [:kinetik]]

I was intending to land this on mozilla-central and let it trickle to B2G that way (so presumably it'd end up in 2.x?).  If you or Michael think we should push it back into 1.x, I have no objections; we'll just need to be more careful with testing.

Comment 9

[Marco Chen [:mchen]]

I think it would be better on V2.0 or V1.2 because chip vendor, partner and Mozilla did much tests on sydney already and LPA seems to be evaluted by chip vendor on sydney now. If the decision is made, I will reply to bug 842195 then start to hack mozWriteAudio API for sydney backend.

So the decision will be on v2.0?
Any suggestion?

Comment 10

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/168b5f190be6

Comment 11

[Matthew Gregan [:kinetik]]

Yep, 2.0 makes sense to me.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/168b5f190be6