848595 - Move HashTableWriteBarrierPost from Barrier.h to Barrier-inl.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

It needs to know about the layout of a JSRuntime to find the StoreBuffer.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 721940 [details] [diff] [review]
v0

Review of attachment 721940 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Barrier-inl.h
@@ +432,5 @@
> +inline void
> +HashTableWriteBarrierPost(JSRuntime *rt, Map *map, const Key &key)
> +{
> +#ifdef JSGC_GENERATIONAL
> +#endif

Don't we need some code here?

Comment 2

[Terrence Cole [:terrence]]

The reason I did not put it here is that we skip putting the item in the store buffer if the key isn't in the nursery, which isn't yet present. Now that I'm thinking about it, we /should/ currently be checking the verifier nursery however: I think this is the reason that some of the tests are failing in the post-barrier verifier right now.

Thanks, I'll get a new patch up.

Comment 3

[Terrence Cole [:terrence]]

Attachment: v1

Was waiting on bug 848199 for this, but it's trivial to just port the bits we need forward.

Comment 4

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38e753b7023f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38e753b7023f