848639 - Prevent DecodeHeader for Ogg Skeleton tracks from failing on valid indexes

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[cajbir (:cajbir)]

DecodeHeader for Ogg Skeleton tracks returns 'false' in the default case when it should probably return true like the other DecodeHeader implementations.

The comment for DecodeHeader states that 'false' means there are no more headers to process but the implementations seem to return 'false' when there is an error, and in the 'no more header' case they set a flag which can be checked by calling another method.

The issue can be shown when playing an Ogg file with a Skeleton index track in a JAR/ZIP file. In this case the duration of the file can be determined without seeking but the implementation of this checks the result of DecodeHeader and bails when it is 'false', deactivating the stream, resulting in no duration being used.

Without the fix, the file http://cd.pn/file2.zip will not allow seeking in the enclosed ogg file. Test by downloading file2.zip locally and trying the URL: jar:file:///home/chris/src/index/file2.zip!/indexed.ogg

Comment 1

[cajbir (:cajbir)]

Attachment: fix

Comment 2

[Jason Smith [:jsmith]]

This blocks a leo blocker, correct?

Comment 3

[Jason Duell]

Is this ready to land?

Comment 4

[cajbir (:cajbir)]

(In reply to Jason Duell (:jduell) from comment #3)
> Is this ready to land?

Yes, waiting for inbound to open and I'll push.

Comment 5

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bbd7ce8308e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6bbd7ce8308e

Comment 7

[Alex Keybl [:akeybl]]

Blocks a blocker.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/138291bd26ad

Comment 9

[Jason Smith [:jsmith]]

Nokia in https://bugzilla.mozilla.org/show_bug.cgi?id=836643#c31 claims they verified this fix. Marking as such.