Closed Bug 848639 Opened 7 years ago Closed 7 years ago
Header for Ogg Skeleton tracks from failing on valid indexes
DecodeHeader for Ogg Skeleton tracks returns 'false' in the default case when it should probably return true like the other DecodeHeader implementations. The comment for DecodeHeader states that 'false' means there are no more headers to process but the implementations seem to return 'false' when there is an error, and in the 'no more header' case they set a flag which can be checked by calling another method. The issue can be shown when playing an Ogg file with a Skeleton index track in a JAR/ZIP file. In this case the duration of the file can be determined without seeking but the implementation of this checks the result of DecodeHeader and bails when it is 'false', deactivating the stream, resulting in no duration being used. Without the fix, the file http://cd.pn/file2.zip will not allow seeking in the enclosed ogg file. Test by downloading file2.zip locally and trying the URL: jar:file:///home/chris/src/index/file2.zip!/indexed.ogg
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Attachment #721971 - Flags: review?(cpearce)
Attachment #721971 - Flags: review?(cpearce) → review+
This blocks a leo blocker, correct?
blocking-b2g: --- → leo?
Is this ready to land?
(In reply to Jason Duell (:jduell) from comment #3) > Is this ready to land? Yes, waiting for inbound to open and I'll push.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks a blocker.
Nokia in https://bugzilla.mozilla.org/show_bug.cgi?id=836643#c31 claims they verified this fix. Marking as such.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.