Last Comment Bug 848675 - Pass app product icon URLs from webpay to Bango
: Pass app product icon URLs from webpay to Bango
Status: RESOLVED FIXED
p=3
:
Product: Marketplace
Classification: Server Software
Component: Payments/Refunds (show other bugs)
: 1.2
: x86 Mac OS X
: P2 normal (vote)
: 2013-04-18
Assigned To: Kumar McMillan [:kumar] (needinfo all the things)
:
:
Mentors:
Depends on:
Blocks: marketplace-payments 856205
  Show dependency treegraph
 
Reported: 2013-03-06 22:16 PST by Kumar McMillan [:kumar] (needinfo all the things)
Modified: 2013-05-16 12:28 PDT (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
20x22 (8.72 KB, image/jpeg)
2013-03-07 11:13 PST, Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com)
no flags Details
2x (10.35 KB, image/jpeg)
2013-03-07 11:14 PST, Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com)
no flags Details

Description Kumar McMillan [:kumar] (needinfo all the things) 2013-03-06 22:16:17 PST
Bango's Billing Config API accepts this undocumented (!) config parameter:

  APP_LOGO_IMG_URL

We need to pass in a URL of the purchased app icon so that the Bango confirmation screen can display it. This is a UX requirement.
Comment 1 Kumar McMillan [:kumar] (needinfo all the things) 2013-03-06 22:23:18 PST
Maureen, what is the optimal width/height for app icons?


Let's do this quick and dirty for Marketplace and make it more robust for in-app payments later. We can accept a new request parameter like:

{
  iss: ...,
  request: {
    name: "Magical Unicorn",
    pricePoint: 1,
    imageURLs: {
      "512": "http://.../unicorn.png"
    }
  }
}

We actually did this in the old in-app handler: https://github.com/mozilla/zamboni/blob/master/mkt/inapp_pay/tasks.py#L94
Comment 2 Maureen Hanratty 2013-03-07 10:57:31 PST
Michael--can you let Kumar know the pixel dimensions for the app icon that appears on the purchase confirmation screen for Payments?
Comment 3 Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com) 2013-03-07 11:13:47 PST
Created attachment 722390 [details]
20x22

20px x 22px
Comment 4 Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com) 2013-03-07 11:14:25 PST
Created attachment 722391 [details]
2x

In case you need it in the future.
Comment 5 Kumar McMillan [:kumar] (needinfo all the things) 2013-03-07 17:43:33 PST
Thanks. Also, can we get a placeholder icon for products that don't have images? This will apply more to in-app payments since those are a bit out of our control.
Comment 6 Keir Kettle 2013-03-20 10:15:19 PDT
(In reply to Kumar McMillan [:kumar] from comment #5)
> Thanks. Also, can we get a placeholder icon for products that don't have
> images? This will apply more to in-app payments since those are a bit out of
> our control.

We use this rocket icon when you dont pass a url, as per 
http://www.mozilla.org/en-US/styleguide/identity/marketplace/branding/
Comment 7 Kumar McMillan [:kumar] (needinfo all the things) 2013-03-29 14:25:19 PDT
I followed up with Michael. All product icons should be 64px x 64px.
Comment 8 Kumar McMillan [:kumar] (needinfo all the things) 2013-04-15 18:38:20 PDT
Zamboni API landed here: https://github.com/mozilla/zamboni/commit/d15423651f4cf86d65e36ab9f12f2c42b559d318
Comment 9 Kumar McMillan [:kumar] (needinfo all the things) 2013-04-16 15:35:36 PDT
Solitude API changes: https://github.com/mozilla/solitude/commit/b38bab1bbfab553d03817d9fd192847d465aae3b
Comment 10 Kumar McMillan [:kumar] (needinfo all the things) 2013-04-17 14:58:45 PDT
WebPay changes: https://github.com/mozilla/webpay/commit/5a49c2a1806d4a92e9d7bae2abc09afd3b538735

It should be ready to go. I'll test it out on the dev server.
Comment 11 Kumar McMillan [:kumar] (needinfo all the things) 2013-04-23 06:19:40 PDT
FYI, we had to disable this because of auth errors. See bug 864451
Comment 12 Kumar McMillan [:kumar] (needinfo all the things) 2013-05-16 12:28:01 PDT
Documentation for this was added in bug 869193

Note You need to log in before you can comment on or make changes to this bug.