Closed
Bug 848685
Opened 13 years ago
Closed 13 years ago
When many flags are set for a patch attachment, the "Mozilla" theme in b.m.o shows them in a single line
Categories
(bugzilla.mozilla.org Graveyard :: Sandstone/Mozilla Skin, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gkw, Unassigned)
References
Details
Attachments
(2 files, 1 obsolete file)
|
25.74 KB,
image/png
|
Details | |
|
337 bytes,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
screenshot
When many flags are set for a patch attachment, the "Mozilla" theme in b.m.o shows them in a single line, so this results in a really long line. See screenshot.
The default Dusk theme does not exhibit this behaviour.
not a regression, as the mozilla skin is new.
No longer blocks: bmo_4_2_regressions
Component: User Interface → Sandstone
|
||
Comment 2•13 years ago
|
||
Also true of group checkboxes, probably a related/similar bug. :)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mcote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•13 years ago
|
||
So br elements in the entire #bz_big_form_parts table are set to "display: none". I'm not sure why, but I presume it's for a good reason, so this patch just undoes that for the attachment flags and group checkboxes.
The attachments table is still a lot wider than in the Dusk skin; I'm not sure if that was done on purpose or not.
Attachment #768705 -
Flags: review?(glob)
Comment on attachment 768705 [details] [diff] [review]
Fix line breaks in attachment flags and group checkboxes
> So br elements in the entire #bz_big_form_parts table are set to "display:
> none". I'm not sure why, but I presume it's for a good reason, so this patch
> just undoes that for the attachment flags and group checkboxes.
i don't see any good reason for that, so instead i would prefer for that clause to be removed.
the only other <br> in #bz_big_form_parts is after the comment textarea, and i don't see any differences display-wise with that br hidden.
Attachment #768705 -
Flags: review?(glob) → review-
|
|
Assignee | |
Comment 6•13 years ago
|
||
Sounds good.
Attachment #768705 -
Attachment is obsolete: true
Attachment #769007 -
Flags: review?(glob)
Comment on attachment 769007 [details] [diff] [review]
Fix line breaks in attachment flags and group checkboxes, v2
r=glob
Attachment #769007 -
Flags: review?(glob) → review+
thanks mark!
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified skins/contrib/Mozilla/global.css
Committed revision 8862.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•