When many flags are set for a patch attachment, the "Mozilla" theme in b.m.o shows them in a single line

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Sandstone/Mozilla Skin
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gkw, Assigned: mcote)

Tracking

Production

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 722094 [details]
screenshot

When many flags are set for a patch attachment, the "Mozilla" theme in b.m.o shows them in a single line, so this results in a really long line. See screenshot.

The default Dusk theme does not exhibit this behaviour.
not a regression, as the mozilla skin is new.
No longer blocks: 848218
Component: User Interface → Sandstone
Also true of group checkboxes, probably a related/similar bug. :)
Duplicate of this bug: 849467
(Assignee)

Updated

4 years ago
Assignee: nobody → mcote
Status: NEW → ASSIGNED
(Assignee)

Comment 4

4 years ago
Created attachment 768705 [details] [diff] [review]
Fix line breaks in attachment flags and group checkboxes

So br elements in the entire #bz_big_form_parts table are set to "display: none". I'm not sure why, but I presume it's for a good reason, so this patch just undoes that for the attachment flags and group checkboxes.

The attachments table is still a lot wider than in the Dusk skin; I'm not sure if that was done on purpose or not.
Attachment #768705 - Flags: review?(glob)
Comment on attachment 768705 [details] [diff] [review]
Fix line breaks in attachment flags and group checkboxes

> So br elements in the entire #bz_big_form_parts table are set to "display:
> none". I'm not sure why, but I presume it's for a good reason, so this patch
> just undoes that for the attachment flags and group checkboxes.

i don't see any good reason for that, so instead i would prefer for that clause to be removed.

the only other <br> in #bz_big_form_parts is after the comment textarea, and i don't see any differences display-wise with that br hidden.
Attachment #768705 - Flags: review?(glob) → review-
(Assignee)

Comment 6

4 years ago
Created attachment 769007 [details] [diff] [review]
Fix line breaks in attachment flags and group checkboxes, v2

Sounds good.
Attachment #768705 - Attachment is obsolete: true
Attachment #769007 - Flags: review?(glob)
Comment on attachment 769007 [details] [diff] [review]
Fix line breaks in attachment flags and group checkboxes, v2

r=glob
Attachment #769007 - Flags: review?(glob) → review+
thanks mark!

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified skins/contrib/Mozilla/global.css
Committed revision 8862.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.