Open Bug 848910 Opened 8 years ago Updated 7 years ago

Support for <group> tag in custom Menu

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

People

(Reporter: sriram, Unassigned)

Details

Attachments

(1 file)

We don't support <group> tag currently. With group tag, the menu items can be made to be exclusively selectable. This can be used by addons, like phony, that allows user to select one of the many choices. This gives parity with Android's implementation.
Attached patch PatchSplinter Review
This adds support for <group> tag. Basically, the individual <item>s take values from the <group> if they don't have a value themselves. This holds good for checkable, enabled, order and visibility.

If an item is exclusively checkable, it will inform the menu, which inturn would uncheck any checked menu-item in the group.
Attachment #722421 - Flags: review?(mark.finkle)
Comment on attachment 722421 [details] [diff] [review]
Patch

This patch could use some comments in GeckoMenu.setExclusiveChecked and when calling GeckoMenu.setExclusiveChecked to let people know that a group action is taking place. I see the Android source even has a few comments about it.
Attachment #722421 - Flags: review?(mark.finkle) → review+
You need to log in before you can comment on or make changes to this bug.