848910 - Support for <group> tag in custom Menu

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

We don't support <group> tag currently. With group tag, the menu items can be made to be exclusively selectable. This can be used by addons, like phony, that allows user to select one of the many choices. This gives parity with Android's implementation.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This adds support for <group> tag. Basically, the individual <item>s take values from the <group> if they don't have a value themselves. This holds good for checkable, enabled, order and visibility.

If an item is exclusively checkable, it will inform the menu, which inturn would uncheck any checked menu-item in the group.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 722421 [details] [diff] [review]
Patch

This patch could use some comments in GeckoMenu.setExclusiveChecked and when calling GeckoMenu.setExclusiveChecked to let people know that a group action is taking place. I see the Android source even has a few comments about it.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.