848937 - Attempting to uninstall robocop should not throw when it is not already installed.

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: patch

In bug 842257 I placed the exception handling higher up the call chain.

See https://github.com/mozilla/autophone/commit/0ec36fd66dfc9c37aacfaaa161c5a2285fd638c3#L0L345

This caused a regression where on a device where robocop had not been previously installed, the uninstallApp would raise an exception that terminated the test run.

Comment 1

[Mark Côté [:mcote]]

Comment on attachment 722447 [details] [diff] [review]
patch

Review of attachment 722447 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/runtestsremote.py
@@ +354,5 @@
>                                            'robocop.apk'),
>                               robocop_apk_path)
> +            try:
> +                self.dm.uninstallApp('org.mozilla.roboexample.test')
> +            except:

Yuck to blanket excepts; we should just catch DMError here.

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 722447 [details] [diff] [review]
patch

Review of attachment 722447 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I'll r+ this just because I don't need to see the fix. :) But please catch just DMError.

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/ad330489735e10242ce6d4a81fdf52a4381d7bca

I had to merge and it appears the history is a bit horked. Not worth making worse imo.