ContextUI.dismiss is async and should return a promise

RESOLVED INCOMPLETE

Status

defect
RESOLVED INCOMPLETE
6 years ago
2 years ago

People

(Reporter: sfoster, Unassigned)

Tracking

Trunk
x86
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=0)

Attachments

(1 attachment)

The css transition trigged by the presence/absence of the visible attribute on the #tray element causes dimiss to be async - the element is not its final height and reflow doesn't happen until later. If it returned a promise, tests (and possibly other code) could more reliably wait for the right time to run.

Updated

6 years ago
Blocks: 834370

Updated

6 years ago
Summary: ContextUI.dimiss is async and should return a promise → ContextUI.dismiss is async and should return a promise

Updated

6 years ago
Assignee: nobody → jmathies

Updated

6 years ago
OS: Windows 8 → Windows 8 Metro
Posted patch patchSplinter Review
Put this together in case it's needed. Now that we have yield hideContextUI() it may not be necessary.

Updated

6 years ago
No longer blocks: 834370

Updated

6 years ago
Assignee: jmathies → nobody
No longer blocks: 888919
Blocks: metrobacklog
Whiteboard: p=0
OS: Windows 8 Metro → Windows 8.1
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.