Adding a comment to a bug causes an internal error

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Needinfo
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: hoosteeno, Assigned: dkl)

Tracking

Production

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 722510 [details]
Bugzilla error message

+++ This bug was initially created as a clone of Bug #848218 +++

I'm attaching a screenshot of an internal error ("Can't call method "login" on an undefined value") I'm receiving from Bugzilla when trying to add a comment to a bug. This hasn't happened on any other bugs I've updated today, so there must be something about this particular circumstance.

Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=836535
Prior comment before this attempt: Comment 1, included a needsinfo (from anyone)
Attempted comment: Some text plus a needsinfo (from someone in particular, input into "other" box)
Are you using Persona to log in?
(Assignee)

Comment 2

4 years ago
Confirmed a bug. Patch coming.
(Assignee)

Comment 3

4 years ago
Created attachment 722520 [details] [diff] [review]
Patch to fix error when checking for matching needinfo requestees (v1)
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #722520 - Flags: review?(glob)
Re: comment 1, I'm pretty sure I used Persona to login. It was days ago; can't recall exactly.
not a regression, just a bug which wasn't encountered/reported until just after the upgrade :)
No longer blocks: 848218
Component: General → Extensions: Needinfo
OS: Mac OS X → All
Hardware: x86 → All
Version: Development/Staging → Production
Comment on attachment 722520 [details] [diff] [review]
Patch to fix error when checking for matching needinfo requestees (v1)

if you have a needinfo directed at you, and you make a comment and request needinfo from anyone, you get:

Use of uninitialized value in string eq at ./extensions/Needinfo/Extension.pm line 115.

also, this patch contains trailing whitespace.
Attachment #722520 - Flags: review?(glob) → review-
(Assignee)

Comment 7

4 years ago
Created attachment 722869 [details] [diff] [review]
Patch to fix error when checking for matching needinfo requestees (v2)
Attachment #722520 - Attachment is obsolete: true
Attachment #722869 - Flags: review?(glob)
Comment on attachment 722869 [details] [diff] [review]
Patch to fix error when checking for matching needinfo requestees (v2)

r=glob
Attachment #722869 - Flags: review?(glob) → review+
(Assignee)

Comment 9

4 years ago
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2         
modified extensions/Needinfo/Extension.pm
Committed revision 8649.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.