849024 - Adding a comment to a bug causes an internal error

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Bugzilla error message

+++ This bug was initially created as a clone of Bug #848218 +++

I'm attaching a screenshot of an internal error ("Can't call method "login" on an undefined value") I'm receiving from Bugzilla when trying to add a comment to a bug. This hasn't happened on any other bugs I've updated today, so there must be something about this particular circumstance.

Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=836535
Prior comment before this attempt: Comment 1, included a needsinfo (from anyone)
Attempted comment: Some text plus a needsinfo (from someone in particular, input into "other" box)

Comment 1

[Dave Miller [:justdave]]

Are you using Persona to log in?

Comment 2

[David Lawrence [:dkl]]

Confirmed a bug. Patch coming.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to fix error when checking for matching needinfo requestees (v1)

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

Re: comment 1, I'm pretty sure I used Persona to login. It was days ago; can't recall exactly.

Comment 5

[:glob ✱]

not a regression, just a bug which wasn't encountered/reported until just after the upgrade :)

Comment 6

[:glob ✱]

Comment on attachment 722520 [details] [diff] [review]
Patch to fix error when checking for matching needinfo requestees (v1)

if you have a needinfo directed at you, and you make a comment and request needinfo from anyone, you get:

Use of uninitialized value in string eq at ./extensions/Needinfo/Extension.pm line 115.

also, this patch contains trailing whitespace.

Comment 7

[David Lawrence [:dkl]]

Attachment: Patch to fix error when checking for matching needinfo requestees (v2)

Comment 8

[:glob ✱]

Comment on attachment 722869 [details] [diff] [review]
Patch to fix error when checking for matching needinfo requestees (v2)

r=glob

Comment 9

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2         
modified extensions/Needinfo/Extension.pm
Committed revision 8649.