Closed
Bug 849115
Opened 13 years ago
Closed 13 years ago
Remove unused code from sms
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
Looks like desktop.js is only used by sms these days, and we can probably get rid of the whole file. The app continues to work without this file.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 722662 [details]
Github pull request pointer
Julien - Think you could give this one a quick review? Thanks!
Attachment #722662 -
Flags: review?(felash)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 722662 [details]
Github pull request pointer
giving this to borja as he already had a look and I don't know this code at all (because I never test in the browser)
Attachment #722662 -
Flags: review?(felash) → review?(fbsc)
|
||
Updated•13 years ago
|
Attachment #722662 -
Flags: review?(fbsc) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Thanks Borja!
Landed in master: https://github.com/mozilla-b2g/gaia/commit/96634d3637940ee91b96d6083f19476e5fd52717
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•