849171 - Console.jsm output of errors could be better

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Joe Walker [:jwalker]]

Using type==Error is too restrictive.
Also the output should be better.

Comment 1

[Joe Walker [:jwalker]]

Attachment: upload 1

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 722712 [details] [diff] [review]
upload 1

Review of attachment 722712 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I've been meaning to ask for better output for console.error() when errors are given. r+ with one minor change below.

::: toolkit/devtools/Console.jsm
@@ +176,5 @@
>          i++;
>        }
>      }
> +    else if (type.match("Error$")) {
> +      reply += "  Message: " + aThing.message + "\n";

aThing.message is sometimes undefined, eg. for XPCOM-related exceptions. I learned this the hard way with a cryptic "undefined" error coming from the debugger client. I had to do dump("error " + ex + "\n") to see the actual error.

Can you change this to reply += " Message: " + aThing + "\n" ?

Comment 3

[Joe Walker [:jwalker]]

Mihai: are you waiting for me to land this before your patch lands, would you like to incorporate this in your patch, or shall I rebase this on your patch? Happy any way.

Comment 4

[Mihai Sucan [:msucan]]

(going through bugmail!)

(In reply to Joe Walker [:jwalker] from comment #3)
> Mihai: are you waiting for me to land this before your patch lands, would
> you like to incorporate this in your patch, or shall I rebase this on your
> patch? Happy any way.

Go ahead and land this patch. Do not wait for my patch. I am happy to rebase my patches on top of this one.

Thanks!

Comment 5

[Joe Walker [:jwalker]]

Attachment: upload 2

Fixes Mihai's comments. Will land with my next push.

Comment 6

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ae9cc383d0f
https://hg.mozilla.org/integration/fx-team/rev/0913fd986ec1

Comment 7

[Joe Walker [:jwalker]]

https://hg.mozilla.org/mozilla-central/rev/0913fd986ec1