Closed Bug 849277 Opened 9 years ago Closed 9 years ago

Remove unused content permission strings for Firefox for Android

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
These strings have not been used for a while, since we no longer use these request types in mobile/android/components/ContentPermissionPrompt.js.

This patch neither depends on nor conflicts with bug 739757; it should apply and work cleanly both before and after those patches land.
Attachment #722847 - Flags: review?(margaret.leibovic)
Comment on attachment 722847 [details] [diff] [review]
patch

Review of attachment 722847 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for helping clean up. This patch actually does conflict a bit with the patches in bug 739757, but feel free to land it first and I can rebase (I'm still working on fixing a test to land my patches in there).

::: mobile/android/locales/en-US/chrome/browser.properties
@@ -132,5 @@
>  offlineApps.storeOfflineData=Store Offline Data
>  
>  # New-style ContentPermissionPrompt values
>  offlineApps.dontAllow=Don't Allow
> -offlineApps.wantsTo=%S wants to store data on your device for offline use.

The first patch in bug 739757 gets rid of this.

@@ -137,4 @@
>  
>  # IndexedDB Quota increases
> -indexedDBQuota.allow=Allow
> -indexedDBQuota.dontAllow=Don't Allow

Same here.

@@ -142,5 @@
>  
> -# Open Web Apps management API
> -openWebappsManage.allow=Allow
> -openWebappsManage.dontAllow=Don't Allow
> -openWebappsManage.wantsTo=%S wants to manage applications on your device.

Good catch with this, though :)
Attachment #722847 - Flags: review?(margaret.leibovic) → review+
(In reply to :Margaret Leibovic from comment #1)
> Thanks for helping clean up. This patch actually does conflict a bit with
> the patches in bug 739757, but feel free to land it first and I can rebase
> (I'm still working on fixing a test to land my patches in there).

Oops!  Somehow I missed the first patch in bug 739757 when I was checking this.  Anyway, thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e3c062230bd
https://hg.mozilla.org/mozilla-central/rev/3e3c062230bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.