849277 - Remove unused content permission strings for Firefox for Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

These strings have not been used for a while, since we no longer use these request types in mobile/android/components/ContentPermissionPrompt.js.

This patch neither depends on nor conflicts with bug 739757; it should apply and work cleanly both before and after those patches land.

Comment 1

[:Margaret Leibovic]

Comment on attachment 722847 [details] [diff] [review]
patch

Review of attachment 722847 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for helping clean up. This patch actually does conflict a bit with the patches in bug 739757, but feel free to land it first and I can rebase (I'm still working on fixing a test to land my patches in there).

::: mobile/android/locales/en-US/chrome/browser.properties
@@ -132,5 @@
>  offlineApps.storeOfflineData=Store Offline Data
>  
>  # New-style ContentPermissionPrompt values
>  offlineApps.dontAllow=Don't Allow
> -offlineApps.wantsTo=%S wants to store data on your device for offline use.

The first patch in bug 739757 gets rid of this.

@@ -137,4 @@
>  
>  # IndexedDB Quota increases
> -indexedDBQuota.allow=Allow
> -indexedDBQuota.dontAllow=Don't Allow

Same here.

@@ -142,5 @@
>  
> -# Open Web Apps management API
> -openWebappsManage.allow=Allow
> -openWebappsManage.dontAllow=Don't Allow
> -openWebappsManage.wantsTo=%S wants to manage applications on your device.

Good catch with this, though :)

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to :Margaret Leibovic from comment #1)
> Thanks for helping clean up. This patch actually does conflict a bit with
> the patches in bug 739757, but feel free to land it first and I can rebase
> (I'm still working on fixing a test to land my patches in there).

Oops!  Somehow I missed the first patch in bug 739757 when I was checking this.  Anyway, thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e3c062230bd

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e3c062230bd