849280 - [Browser] Long initial startup time for Browser app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Michał Budzyński (:michalbe)]

With avg of 1.2s its the second slowest app in Gaia now.

Comment 1

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

bug 843852 may be related

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 722855 [details]
patch

r=me

Comment 4

[Michał Budzyński (:michalbe)]

Thanks Ben.

Merged:
https://github.com/mozilla-b2g/gaia/commit/e3e313b236ccc8a389c7cf53b10959d7aef2ed88

Comment 5

[Julien Wajsberg [:julienw]]

Michal, can you tell us what is the perf gain with this patch ?

Comment 6

[Julien Wajsberg [:julienw]]

note: this will need Bug 841251 uplifted before uplifting this.

Comment 7

[Michał Budzyński (:michalbe)]

It's around 450ms

Comment 8

[Michael Vines [:m1] [:evilmachines]]

(for v1.0.1, I think we are generally content with the browser app start time so passing this along to leo? for consideration)

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Another reason to have this nomed and uplifted.  bug 849917 is fixed for v1 train if this lands in v1 train.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 722855 [details]
patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: browser starts slower AND Bug 849917 is still there
Testing completed: yes
Risk to taking this patch (and alternatives if risky): the patch is not the safest (changes in the lazy loader) but it was tested and it landed for 1 week in master already. + there are unit tests for the added functionality in lazy_loadder.js
String or UUID changes made by this patch: none

Comment 11

[Ben Francis [:benfrancis]]

Bug 836647 is tef+ and needs to be uplifted to 1.0.1, but that patch introduces a regression which is fixed by this bug. Without this fix we can not uplift bug 836647, so should this bug be tef+ too?

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 722855 [details]
patch

Approving for v1.1 given perf wins - would recommend against uplift to v1.0.1.

Comment 13

[Ben Francis [:benfrancis]]

If this is not tef+ then bug 836647 can not be tef+ because uplifting it would cause a regression.

Comment 14

[Michael Vines [:m1] [:evilmachines]]

(tef+ based on comment 13)

Comment 15

[Ben Francis [:benfrancis]]

I've uplifted this to v1-train myself now that it has approval because it has merge conflicts that needed resolving, and because it fixes a regression caused by uplifting bug 836647 which needed fixing sooner than later.

https://github.com/mozilla-b2g/gaia/commit/7af427d35c4d557c75b2060022815f07851acc28

Still not uplifted to v1.0.1

Comment 16

[Julien Wajsberg [:julienw]]

Ben, don't forget to set the flags when you uplift ;)

Comment 17

[Ben Francis [:benfrancis]]

What does status-b2g18: fixed mean? Is that how you flag something as fixed on Gaia v1-train?!

Comment 18

[Julien Wajsberg [:julienw]]

yes ;)

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Ben Francis [:benfrancis] from comment #15) 
> https://github.com/mozilla-b2g/gaia/commit/
> 7af427d35c4d557c75b2060022815f07851acc28
> 
> Still not uplifted to v1.0.1

Is this uplift something that you'd be able to take care of?  There are lots of conflicts that I am not sure how to resolve.

Comment 20

[Ben Francis [:benfrancis]]

e3e313b236ccc8a389c7cf53b10959d7aef2ed88 uplifted to v1.0.1 as d8c844c8b89bb453b49c7a4107686bf97050e985

Comment 21

[amiller]

No need to create a test case in Moztrap for this issue.

Comment 22

[mdaniloff]

Verified fixed in Unagi V1 and V.1.01:
according to the "show time to load" setting in the Developer screen, the load time is 475

Unagi V1
Unagi Build ID: 20130401070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f9f11b8cbf8a
Gaia: 663101b6eb809383e5882d9bc3868a923a57998a

Unagi build V.1.0.1
Unagi Build ID: 20130401070203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b28463f2e718
Gaia: ddb38ac8a34f9e30e09d0ff3b5c1bfb9b664b7c3

Comment 23

[Julien Wajsberg [:julienw]]

I doubt the load time is 475. I believe you tried to launch it while it was already loaded.

The correct STR to measure the startup time of an app is :
* long press the home button
* kill any instance of the app
* press home to go back to homescreen
* launch the app

6 seconds must have elapsed since the last launch.