849289 - Turn off the Desktop Notifications (mozNotifications) API in Metro

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

We don't have desktop notifications implemented for WinRT, so we should disable this API and remove the associated strings and code for now.  We are planning to implement the API sometime after v1 (bug 801185).

Comment 1

[Jim Mathies [:jimm]]

Was this hooked up to anything or was it just dead code? I can't find much in mxr for 'notification.feature.enabled', but it seems like most platforms have it enabled.

Comment 2

[Matt Brubeck (:mbrubeck)]

notification.feature.enabled is currently turned on only for Android and B2G.

The implementation uses nsIAlertsService, which in Metro Firefox just displays a XUL popup within the browser window.  This is useless for Desktop Notifications, which are supposed to show a system-wide alert that is visible even when you aren't using the browser.

To implement it properly, we'd need a WinRT nsIAlertsService implementation that uses Windows.UI.Notifications.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 722864 [details] [diff] [review]
patch

I was worried this would kill in browser alerts, but apparently it does not.

Comment 4

[Matt Brubeck (:mbrubeck)]

Right, this only affects web content; it has no effect on our chrome alerts.

https://hg.mozilla.org/integration/mozilla-inbound/rev/09bb2980eafb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/09bb2980eafb