Created attachment 722864 [details] [diff] [review] patch We don't have desktop notifications implemented for WinRT, so we should disable this API and remove the associated strings and code for now. We are planning to implement the API sometime after v1 (bug 801185).
Attachment #722864 - Flags: review?(jmathies)
Was this hooked up to anything or was it just dead code? I can't find much in mxr for 'notification.feature.enabled', but it seems like most platforms have it enabled.
notification.feature.enabled is currently turned on only for Android and B2G. The implementation uses nsIAlertsService, which in Metro Firefox just displays a XUL popup within the browser window. This is useless for Desktop Notifications, which are supposed to show a system-wide alert that is visible even when you aren't using the browser. To implement it properly, we'd need a WinRT nsIAlertsService implementation that uses Windows.UI.Notifications.
Comment on attachment 722864 [details] [diff] [review] patch I was worried this would kill in browser alerts, but apparently it does not.
Attachment #722864 - Flags: review?(jmathies) → review+
Right, this only affects web content; it has no effect on our chrome alerts. https://hg.mozilla.org/integration/mozilla-inbound/rev/09bb2980eafb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.