849334 - Uplift profiler changes to b2g18

Status: RESOLVED WONTFIX

(Core :: Gecko Profiler, defect)

Description

[Gregor Wagner [:gwagner]]

Some profiler enhancements are only available on trunk. My impression is that we might need the b2g18 branch for a little longer. We need the best tools for performance work/profiling and should uplift relevant patches.
BenWa suggested uplifting tools/profiler/*
The profiler is disabled for B2G builds and only available with a compile flag.
BenWa, is there any risk involved with uplifting?

Comment 1

[Benoit Girard (:BenWa)]

(In reply to Gregor Wagner [:gwagner] from comment #0)
> The profiler is disabled for B2G builds and only available with a compile
> flag.

I haven't seen that. It not active by default but always compile on other Tier-1 platform.

> BenWa, is there any risk involved with uplifting?

No there isn't until we merge the new breakpad unwinding changes from bug 779291 which we cannot uplift without a considerable effort. But there's no rush since we can just uplift the revision before that change lands.

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Ok it's not that easy :(

Comment 4

[Gregor Wagner [:gwagner]]

So this patch doesn't compile when the profiler is disabled but it works fine for b2g18 builds when the profiler is enabled.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

When you have something that will not break builds, please nominate for uplift approval :)

Comment 6

[Benoit Girard (:BenWa)]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> So this patch doesn't compile when the profiler is disabled but it works
> fine for b2g18 builds when the profiler is enabled.

Whats the compile error?

Comment 7

[Gregor Wagner [:gwagner]]

(In reply to Benoit Girard (:BenWa) from comment #6)
> (In reply to Gregor Wagner [:gwagner] from comment #4)
> > So this patch doesn't compile when the profiler is disabled but it works
> > fine for b2g18 builds when the profiler is enabled.
> 
> Whats the compile error?

Yeah I should have posted them right away!

nsNativeThemeCocoa.mm
/Volumes/mac/moz/b2g18/widget/cocoa/nsAppShell.mm:227:3: error: unexpected '@'
      in program
  NS_OBJC_BEGIN_TRY_ABORT_BLOCK;
  ^
../../dist/include/nsObjCExceptions.h:180:39: note: expanded from macro
      'NS_OBJC_BEGIN_TRY_ABORT_BLOCK'
#define NS_OBJC_BEGIN_TRY_ABORT_BLOCK @try {
                                      ^
/Volumes/mac/moz/b2g18/widget/cocoa/nsAppShell.mm:258:3: error: unexpected '@'
      in program
  NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
  ^
../../dist/include/nsObjCExceptions.h:201:48: note: expanded from macro
      'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT'
#define NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT @try {
                                               ^
/Volumes/mac/moz/b2g18/widget/cocoa/nsAppShell.mm:369:3: error: unexpected '@'

Comment 8

[Ed Morley [:emorley]]

Given bug 875164, this is wontfix.