849589 - Intermittent robocop PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20496559&tree=Mozilla-Inbound

Android 4.0 Panda mozilla-inbound opt test robocop-2 on 2013-03-09 15:10:16 PST for push 80f3b6ae39bb
slave: panda-0563

0 INFO SimpleTest START
1 INFO TEST-START | testAddonManager
waitForText timeout on ^Add-ons$
2 INFO TEST-PASS | testAddonManager | Page title is correct - Add-ons should equal Add-ons
3 INFO TEST-PASS | testAddonManager | Awesomebar URL typed properly - about:addons should equal about:addons
4 INFO TEST-PASS | testAddonManager | Page title is correct - Add-ons should equal Add-ons
5 INFO TEST-PASS | testAddonManager | The correct number of tabs are opened - 2 should equal 2
6 INFO TEST-PASS | testAddonManager | Page title is correct - Browser Blank Page 01 should equal Browser Blank Page 01
waitForText timeout on ^Add-ons$
7 INFO TEST-PASS | testAddonManager | The correct number of tabs are opened - 2 should equal 2
8 INFO TEST-END | testAddonManager | finished in 66096ms
9 INFO TEST-START | Shutdown
10 INFO Passed: 6
11 INFO Failed: 0
12 INFO Todo: 0
13 INFO SimpleTest FINISHED
INFO | automation.py | Application ran for: 0:01:11.338057
INFO | automation.py | Reading PID log: /tmp/tmpMqgf0ypidlog
PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)
WARNING | automationutils.processLeakLog() | refcount logging is off, so leaks can't be detected!

INFO | runtests.py | Running tests: end.

Comment 2

[Mike Hommey [:glandium]]

This doesn't make much sense.

Comment 3

[Scoobidiver (away)]

See https://crash-stats.mozilla.com/report/list?signature=java.lang.RuntimeException%3A+Only+ByteBufferInputStream+is+supported+at+org.mozilla.gecko.mozglue.NativeZip.%3Cinit%3E%28NativeZip.java%29

Comment 4

[Legacy TBPL/Treeherder Robot]

rnewman
https://tbpl.mozilla.org/php/getParsedLog.php?id=20635967&tree=Mozilla-Inbound
Android 4.0 Panda mozilla-inbound opt test robocop-2 on 2013-03-13 22:18:15
slave: panda-0586

DMError: Automation Error: Timeout in command exec "MOZ_CRASHREPORTER=1,XPCOM_DEBUG_BREAK=stack,MOZ_HIDE_RESULTS_TABLE=1,MOZ_CRASHREPORTER_NO_REPORT=1,NO_EM_RESTART=1,MOZ_PROCESS_LOG=/tmp/tmp1xUowApidlog,XPCOM_MEM_BLOAT_LOG=/mnt/sdcard/tests/profile/runtests_leaks.log" am instrument -w -e deviceroot /mnt/sdcard/tests -e class org.mozilla.fennec.tests.testBrowserProvider org.mozilla.roboexample.test/org.mozilla.fennec.FennecInstrumentationTestRunner
PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 5

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=20853491&tree=Mozilla-Inbound
Android Tegra 250 mozilla-inbound opt test robocop-2 on 2013-03-19 17:04:17
slave: tegra-146

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 6

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=21000708&tree=Mozilla-Inbound
Android Armv6 Tegra 250 mozilla-inbound opt test jsreftest-2 on 2013-03-22 19:03:07
slave: tegra-112

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 7

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=21042939&tree=Mozilla-Inbound
Android Armv6 Tegra 250 mozilla-inbound opt test robocop-1 on 2013-03-24 19:58:07
slave: tegra-357

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)
PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 8

[Legacy TBPL/Treeherder Robot]

ewong
https://tbpl.mozilla.org/php/getParsedLog.php?id=21048801&tree=Mozilla-Inbound
Android Tegra 250 mozilla-inbound opt test robocop-1 on 2013-03-24 23:55:07
slave: tegra-223

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 9

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=21290460&tree=Try
Android Tegra 250 try opt test robocop-1 on 2013-03-30 20:29:32
slave: tegra-040

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 10

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=21537846&tree=Mozilla-Inbound
Android Armv6 Tegra 250 mozilla-inbound opt test robocop-2 on 2013-04-07 19:08:47
slave: tegra-201

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 11

[Chris Peterson [:cpeterson]]

glandium, I think this NativeZip exception might be caused when NativeZip.createInputStream() returns an InflaterInputStream instead of ByteBufferInputStream here:

https://hg.mozilla.org/mozilla-central/file/b0d842380959/mobile/android/base/mozglue/NativeZip.java#l76

InflaterInputStream is not an instance of ByteBufferInputStream.

Comment 12

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=21864012&tree=Mozilla-Central
Android Armv6 Tegra 250 mozilla-central opt test robocop-2 on 2013-04-16 07:51:43
slave: tegra-166

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:30)

Comment 13

[Chris Peterson [:cpeterson]]

glandium, why does the NativeZip reject InputStreams that are not ByteBufferInputStream instances when NativeZip.createInputStream() can return an InflaterInputStream? Please see comment 11.

Comment 14

[Mike Hommey [:glandium]]

(In reply to Chris Peterson (:cpeterson) from comment #13)
> glandium, why does the NativeZip reject InputStreams that are not
> ByteBufferInputStream instances when NativeZip.createInputStream() can
> return an InflaterInputStream? Please see comment 11.

Because while it can theoretically be supported, it's not necessary. Which is why I wrote comment 2. This error can theoretically not happen, because it would require the omni.ja to be deflated which it is not.

Comment 15

[Chris Peterson [:cpeterson]]

Attachment: add-exception-info.patch

Add more descriptive error messages to NativeZip exceptions. This patch does not fix the crash, but it adds more details about what's going wrong to the exception description that is logged.

I also removed the InflaterInputStream code because you said it should never happen (and if it *did*, the NativeZip constructor's `instanceof ByteBufferInputStream` would fail like it is now).

Here is an Android try build with these exceptions:

https://tbpl.mozilla.org/?tree=Try&rev=6442a9d8f192

Comment 16

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0908e4d4892f

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0908e4d4892f

Comment 19

[Aaron Train [:aaronmt]]

STR: Open a 'New Private Tab'

bp-9c146cdd-fcac-4ec7-8b64-a31422130422

--
Nightly (04/22)
LG Nexus 4 (Android 4.2.2)

Comment 20

[Scoobidiver (away)]

More reports also at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A+Got+class+java.util.zip.InflaterInputStream%2C+but+expected+ByteBufferInputStream!+at+org.mozilla.gecko.mozglue.NativeZip.%3Cinit%3E%28NativeZip.java%29

Comment 21

[Mike Hommey [:glandium]]

Were the problems before landing the original patch about opening a "New Private Tab"?

Comment 22

[Chris Peterson [:cpeterson]]

(In reply to Mike Hommey [:glandium] from comment #21)
> Were the problems before landing the original patch about opening a "New
> Private Tab"?

No. The original problem was the intermittent robocop crash. I think I should back out all my NativeZip changes. Then we only have the robocop problems and no Private Browsing crashes.

Comment 23

[Mike Hommey [:glandium]]

(In reply to Chris Peterson (:cpeterson) from comment #22)
> (In reply to Mike Hommey [:glandium] from comment #21)
> > Were the problems before landing the original patch about opening a "New
> > Private Tab"?
> 
> No. The original problem was the intermittent robocop crash. I think I
> should back out all my NativeZip changes. Then we only have the robocop
> problems and no Private Browsing crashes.

Wasn't bug 849639 supposed to fix that? The remainder should be related to the original robocop crashes, but with a more accurate log, shouldn't it?

Comment 24

[Chris Peterson [:cpeterson]]

Yes, I spoke too soon. The crash report linked from comment 20 was in build 2013-04-25, which has the "New Private Tab" crash fix. (I just verified.) So that crash report must be for a different compressed resource. I don't know why these crashes would be intermittent.

Comment 25

[Scoobidiver (away)]

It's #7 top crasher in 22.0a2 and #23 in 23.0a1.

Comment 26

[Brad Lassey [:blassey] (use needinfo?)]

tracking for the regression

Comment 27

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=23102200&tree=Mozilla-Beta
Android Tegra 250 mozilla-beta opt test robocop-2 on 2013-05-17 18:57:57
slave: tegra-087

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 28

[Chris Peterson [:cpeterson]]

Attachment: Catch and log intermittent NativeZip exception. r=

Comment 29

[Chris Peterson [:cpeterson]]

Comment on attachment 754173 [details] [diff] [review]
Catch and log intermittent NativeZip exception. r=

Catch and log intermittent NativeZip exception. I still can't reproduce this intermittent exception locally, so this patch is a temporary band-aid, not a real fix. Since this is a topcrash in the field, I'd like to catch and ignore this exception in Aurora 23 and Beta 22.

For Nightly 24, I will post a follow-up patch that throws an exception with a more descriptive message for testing.

Comment 30

[Chris Peterson [:cpeterson]]

Attachment: Rethrow intermittent NativeZip exception with more debugging info. r=

Comment 31

[Chris Peterson [:cpeterson]]

Comment on attachment 754178 [details] [diff] [review]
Rethrow intermittent NativeZip exception with more debugging info. r=

Rethrow intermittent NativeZip exception with more debugging info. This band-aid patch is intended for Nightly only. It does not mask the NativeZip exception (like my other patch), but it includes the full jar:jar: URL of the problematic resource. This should make tracking down this intermittent exception easier.

Comment 32

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24d2497e1fa9
https://hg.mozilla.org/integration/mozilla-inbound/rev/07cbebfba8c1

Comment 33

[Chris Peterson [:cpeterson]]

Comment on attachment 754173 [details] [diff] [review]
Catch and log intermittent NativeZip exception. r=

[Approval Request Comment]
Bug caused by (feature/regressing bug #): We don't know.
User impact if declined: Continued topcrash on Android.
Testing completed (on m-c, etc.): Locally.
Risk to taking this patch (and alternatives if risky): Low risk band-aid patch. This is not a complete fix! This patch just catches an intermittent exception and returns null, which is already a valid return value for this function. The caller code will just skip the loading of a resource image. We can then wait for any bug reports about missing resource images.
String or IDL/UUID changes made by this patch: N/A

Comment 34

[Chris Peterson [:cpeterson]]

Comment on attachment 754178 [details] [diff] [review]
Rethrow intermittent NativeZip exception with more debugging info. r=

And just to be clear, this second patch ("Rethrow intermittent NativeZip exception") SHOULD NOT be uplifted because it is debugging code that will still throw (more informative) exceptions!

Comment 35

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/07cbebfba8c1
https://hg.mozilla.org/mozilla-central/rev/24d2497e1fa9

Comment 36

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6d0f086b6da2

Comment 37

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-beta/rev/356ba7a33226

Comment 38

[Scoobidiver (away)]

There are still crashes in 22.0b3: #27 crasher.

Comment 39

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=23687911&tree=Mozilla-Beta
Android Armv6 Tegra 250 mozilla-beta opt test robocop-2 on 2013-06-01 19:53:56
slave: tegra-042

PROCESS-CRASH | java-exception | java.lang.RuntimeException: Only ByteBufferInputStream is supported	at org.mozilla.gecko.mozglue.NativeZip.<init>(NativeZip.java:32)

Comment 40

[Scoobidiver (away)]

Here is a crash report with debug info: bp-86fb7a19-0fe3-40e6-badf-66cbd2130601.

Comment 41

[Chris Peterson [:cpeterson]]

(In reply to Scoobidiver from comment #40)
> Here is a crash report with debug info:
> bp-86fb7a19-0fe3-40e6-badf-66cbd2130601.

java.lang.IllegalArgumentException: !!! BUG 849589 !!! origUrl=jar:jar:file:///data/app/org.mozilla.fennec-2.apk!/omni.ja!/chrome/chrome/content/branding/favicon64.png
	at org.mozilla.gecko.util.GeckoJarReader.getStream(GeckoJarReader.java:115)
	at org.mozilla.gecko.util.GeckoJarReader.getBitmapDrawable(GeckoJarReader.java:43)
	at org.mozilla.gecko.util.GeckoJarReader.getBitmap(GeckoJarReader.java:30)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java:286)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:380)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:245)
	at org.mozilla.gecko.util.UiAsyncTask$BackgroundTaskRunnable.run(UiAsyncTask.java:48)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)

Comment 42

[Alex Keybl [:akeybl]]

(In reply to Scoobidiver from comment #38)
> There are still crashes in 22.0b3: #27 crasher.

We may untrack given the latest crash volume. Does this qualify as a topcrash on any branch at this point?

Comment 43

[Scoobidiver (away)]

(In reply to Alex Keybl [:akeybl] from comment #42)
> We may untrack given the latest crash volume. Does this qualify as a
> topcrash on any branch at this point?
With combined signatures (comment 38 was for one signature at the beginning of 22.0b3), it's #13 crasher in 22.0b3 (#12 unfixed) so technically not a top crasher but very close to the Android threshold.

Comment 44

[Brad Lassey [:blassey] (use needinfo?)]

not a top crash, moving to a minus

Comment 45

[Scoobidiver (away)]

It's #5 top crasher in 22.0 and #55 in 23.0a2.

Comment 46

[Brad Lassey [:blassey] (use needinfo?)]

so not a top crasher for anything but release

Comment 47

[Scoobidiver (away)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #46)
> so not a top crasher for anything but release
Some kinds of startup crashes behave that way either a top crasher in the first regressing version or a top crasher only for Release and Beta (23.0b1 is not yet released).
You assumed the first assumption. If it's the second, I'll ask again a tracking.

Comment 48

[Alex Keybl [:akeybl]]

We'll wait to hear back on b1 and comment 47 before making a decision on tracking

Comment 49

[Alex Keybl [:akeybl]]

Please renom if this continues to be a top crash for FF23.

Comment 50

[Scoobidiver (away)]

It's only #178 crasher in 23.0b1.

Comment 51

[Scoobidiver (away)]

It's not a top crasher for any current channels: #59 in 23.0 for instance.