Last Comment Bug 849612 - Fix build problems caused by Bug 847195 [error: nsIDOMNamedNodeMap.h: No such file or directory]
: Fix build problems caused by Bug 847195 [error: nsIDOMNamedNodeMap.h: No such...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Composition (show other bugs)
: Trunk
: All All
: -- blocker with 1 vote (vote)
: Thunderbird 22.0
Assigned To: neil@parkwaycc.co.uk
:
:
Mentors:
Depends on:
Blocks: 847195
  Show dependency treegraph
 
Reported: 2013-03-10 01:59 PST by Frank Wein [:mcsmurf]
Modified: 2013-03-11 11:49 PDT (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (8.37 KB, patch)
2013-03-10 03:54 PDT, :Ms2ger (⌚ UTC+1/+2)
no flags Details | Diff | Splinter Review
Patch v1.1 (9.14 KB, patch)
2013-03-10 05:59 PDT, :Ms2ger (⌚ UTC+1/+2)
no flags Details | Diff | Splinter Review
Possible patch (7.60 KB, patch)
2013-03-11 02:58 PDT, neil@parkwaycc.co.uk
standard8: review+
Ms2ger: feedback+
Details | Diff | Splinter Review

Description Frank Wein [:mcsmurf] 2013-03-10 01:59:15 PST
It looks like Bug 847195 removed the nsIDOMNamedNodeMap class, due to that build failure(s?) occur, from SeaMonkey build log:
[...]
/builds/slave/c-cen-t-lnx-ntly/build/mailnews/compose/src/nsMsgCompose.cpp:17:32: fatal error: nsIDOMNamedNodeMap.h: No such file or directory
[...]
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2013-03-10 03:54:00 PDT
Created attachment 723188 [details] [diff] [review]
Patch v1

I changed the code to use more well-supported APIs, because there's a good chance I'd break this code again soon if I didn't.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2013-03-10 05:59:56 PDT
Created attachment 723194 [details] [diff] [review]
Patch v1.1

With build errors fixed.
Comment 3 Frank Wein [:mcsmurf] 2013-03-10 14:19:19 PDT
Actually I think those two guys are better reviewers for this :)
Comment 4 :aceman 2013-03-11 00:55:09 PDT
Why isn't msgCompose changed to use nsDOMMozNamedAttrMap.h as the files in the respective mozilla.central patch? It appears to me the mozilla namespace adds quite a lot of compile time. But I haven't benchmarked it precisely.
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2013-03-11 01:02:58 PDT
No idea what you're talking about with the compile time. The reason I'm not using nsIDOMMozNamedAttrMap is because I want to kill that interface.
Comment 6 neil@parkwaycc.co.uk 2013-03-11 02:33:10 PDT
Comment on attachment 723194 [details] [diff] [review]
Patch v1.1

Although by default mailnews gets linked into libxul I'd appreciate it if you avoided libxul-only code so that it can build against xulrunner.
Comment 7 neil@parkwaycc.co.uk 2013-03-11 02:58:22 PDT
Created attachment 723385 [details] [diff] [review]
Possible patch
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2013-03-11 03:00:37 PDT
Comment on attachment 723385 [details] [diff] [review]
Possible patch

Review of attachment 723385 [details] [diff] [review]:
-----------------------------------------------------------------

This would work for now, yes.
Comment 9 Mark Banner (:standard8, limited time in Dec) 2013-03-11 04:19:59 PDT
Comment on attachment 723385 [details] [diff] [review]
Possible patch

Review of attachment 723385 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.
Comment 10 neil@parkwaycc.co.uk 2013-03-11 06:44:19 PDT
Pushed comm-central changeset 7bf5abf3214d.
Comment 11 :aceman 2013-03-11 07:29:54 PDT
Do we obsolete the patch v1.1 or is that open for a way to fix this in a different way in the future?
Comment 12 :Ms2ger (⌚ UTC+1/+2) 2013-03-11 08:32:19 PDT
Comment on attachment 723194 [details] [diff] [review]
Patch v1.1

This won't work at this point.

Note You need to log in before you can comment on or make changes to this bug.