849654 - Kill multithreaded hashtables

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Kill nsClassHashtableMT

Unused in mozilla-central and comm-central.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Remove the only use of nsDataHashtableMT

There's a lock protecting the hashtable, so we don't need the MT version of the hashtable anyways.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Kill nsDataHashtableMT

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Remove the only use of nsRefPtrHashtableMT

There's an array in this class that is manipulated at the same points the hashtable is without any locking, so I assume the hashtable doesn't need a lock.

Comment 5

[Benjamin Smedberg]

Comment on attachment 723231 [details] [diff] [review]
Kill nsClassHashtableMT

God love you.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2a81fcf82fd

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad9ab32b68ab
https://hg.mozilla.org/integration/mozilla-inbound/rev/34798ef80ec1

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f2a81fcf82fd
https://hg.mozilla.org/mozilla-central/rev/ad9ab32b68ab
https://hg.mozilla.org/mozilla-central/rev/34798ef80ec1

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 723289 [details] [diff] [review]
Remove the only use of nsRefPtrHashtableMT

I think your analysis is right, but I'd prefer Neil to take a look.

Comment 10

[[e-mail]]

Comment on attachment 723289 [details] [diff] [review]
Remove the only use of nsRefPtrHashtableMT

Indeed, nsIMAPHostSessionList (the only caller) does the locking already.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/comm-central/rev/b7d4685da976

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Kill nsRefPtrHashtableMT

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b436cad50c33

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And this was finished in bug 910989.