849699 - Defect - Cannot Select Email/Password Text Boxes on Twitter

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

When visiting Twitter using the Metro browser, sometimes you cannot place the cursor into the Email/Password fields making it impossible to login. You have to refresh the website until you can place the cursor into the fields. If you do place the cursor inside the fields, you will notice a very large border appear around the selected field.

Steps to reproduce the issue:

1) Open the Metro browser
2) Go to the Twitter page (make sure you are not logged in)
3) Try inserting your cursor into either the Email or Password fields (If you do end up selecting the fields, you will notice a border appear around the selected field)

Actual Results:

- Cannot select the Email or Password fields (or a border appears when you do end up selecting them)

Expected Results:

- Should be able to select the fields without any problems and no borders

Comment 1

[Brian R. Bondy [:bbondy]]

Confirmed, ouch! We should fix this soon.
Username and password fields will not accept focus.

Comment 2

[Brian R. Bondy [:bbondy]]

I noticed that you can hit the tab key with your keyboard to get focus in the username and password fields, but touch and mouse do not work.

Comment 3

[Jim Mathies [:jimm]]

Do we have a regression range on this, or has it always been broken?

Comment 4

[Kamil Jozwiak [:kjozwiak]]

I'm not sure if it was always broken but I'll try an older build and if it doesn't work then I'll use mozregression ( http://mozilla.github.com/mozregression/ ) to find the regression range.

Comment 5

[Asa Dotzler [:asa]]

Yeah. This is top 10 site. We gotta get touch focusing the forms and bringing up the OSK.

Comment 6

[Brian R. Bondy [:bbondy]]

This is not just touch by the way Asa, you can't even select it with your mouse.

Comment 7

[Marco Mucci [:MarcoM]]

Hi Asa, is this defect better represented by a story from iterations #0 - #3?

Comment 8

[Brian R. Bondy [:bbondy]]

Marco I'll mark it as blocking story bug 801121 for now, but I'm not sure if it was introduced there.  We can change it later if needed. Once Kamil does the regression range we will know better.

Comment 9

[Brian R. Bondy [:bbondy]]

Actually bug 831977 is probably a better guess.

Comment 10

[Marco Mucci [:MarcoM]]

Sounds good.  Thanks for the update Brian.

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Works:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/01/2013-01-31-04-02-03-elm/

Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-16-03-11-27-mozilla-central/

Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-10-04-02-02-elm/

Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-05-04-02-03-elm/

Works:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-02-04-02-02-elm/

Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-04-04-02-02-elm/

No build for 2013-02-03 for elm so the regression range is:

- 2013-02-02 to 2013-02-04

LoginManager looks like it landed within this range and so I think the blocking bug is the right one.

Comment 12

[Brian R. Bondy [:bbondy]]

Awesome, thank you!

Comment 13

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/elm/rev/8fc5aeb14b6f
https://hg.mozilla.org/projects/elm/rev/cbb24f3d4d11
https://hg.mozilla.org/projects/elm/rev/d788e35a91ba

Comment 14

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l1.62

Comment 15

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Removing this code in the attached patch makes focus work correctly for the sign in fields on twitter.com.  It also doesn't break autocomplete in general in any way I can see. 

Maybe it's related to removing this previously but I re-enabled that and it didn't help the problem.
https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l2.12

I think we should take this for now but let me know if you have a better suggestion.

Comment 16

[Brian R. Bondy [:bbondy]]

I think it is correct. It seems like these lines:
https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l2.19

Were at one point enabled and that's why the extra focus code was needed.
But when those lines were commented out (at some point by someone) they didn't update the code in this patch.

Comment 17

[Brian R. Bondy [:bbondy]]

Thanks for the quick reviews (that you always give :)).
By the way I still plan to get to the login manager tests as I have time between iteration tasks.

Comment 18

[Brian R. Bondy [:bbondy]]

inbound has been down for a while, marking checkin-needed.

Comment 19

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2.

Same but with a proper commit message

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e90fa0a09ac5

Comment 22

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e90fa0a09ac5

Comment 23

[Kamil Jozwiak [:kjozwiak]]

Tried reproducing the issue using the latest Nightly build without any issues:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-17-03-09-23-mozilla-central/

Went through the same steps as posted before without any problems. Tried several other websites such as Facebook to make sure its working correctly.

Removing need info since I think I'm providing the info needed to verify this task.

Comment 24

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

Once again, went through the original test case in Comment 0 and also tried several other websites without any issues.

Comment 25

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-21-05-01-36-mozilla-central/

- Went through the original test case in comment #0 without any issues
- Tried several other websites and ensured that you can tab/click into the username and password fields
- Went through all of the above test cases in filled view without any issues