849725 - B2G RIL: remove RIL.iccInfoPrivate.SPN.spn

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

This properity isn't used and the spn string is also stored in RIL.iccInfo.spn. We can remove spn string from iccInfoPrivate.

Comment 1

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Remove spn from iccInfoPriv.SPN

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 749126 [details] [diff] [review]
Remove spn from iccInfoPriv.SPN

Review of attachment 749126 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +10166,1 @@
>        };

It seems we can make it become
RIL.iccInfoPrivate.spnDisplayCondtion, without wrapping by another SPN object, right?

Comment 3

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch: use iccInfoPriv.spnDisplayCondition to store display condition

Comment 4

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch: use iccInfoPriv.spnDisplayCondition to store display condition v3

fix xpcshell failure.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 749723 [details] [diff] [review]
Patch: use iccInfoPriv.spnDisplayCondition to store display condition v3

Review of attachment 749723 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +11219,3 @@
>            iccInfo.isDisplayNetworkNameRequired = true;
>          } else {
>            iccInfo.isDisplayNetworkNameRequired = false;

we could make this remove this if block by
iccInfo.isDisplayNetworkNameRequired = (displayCondition & 0x01) != 0;

also with & 0x2 below.

But it doesn't matter too much so I leave you to decide.

Comment 6

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

https://hg.mozilla.org/projects/birch/rev/7c9620071088

Comment 7

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch: use iccInfoPriv.spnDisplayCondition to store display condition (check in version)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7c9620071088