B2G RIL: remove RIL.iccInfoPrivate.SPN.spn

RESOLVED FIXED in Firefox 24

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kk1fff, Assigned: kk1fff)

Tracking

unspecified
mozilla24
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox22 wontfix, firefox23 wontfix, firefox24 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

This properity isn't used and the spn string is also stored in RIL.iccInfo.spn. We can remove spn string from iccInfoPrivate.
Created attachment 749126 [details] [diff] [review]
Remove spn from iccInfoPriv.SPN
Attachment #749126 - Flags: review?(allstars.chh)
Comment on attachment 749126 [details] [diff] [review]
Remove spn from iccInfoPriv.SPN

Review of attachment 749126 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +10166,1 @@
>        };

It seems we can make it become
RIL.iccInfoPrivate.spnDisplayCondtion, without wrapping by another SPN object, right?
Created attachment 749186 [details] [diff] [review]
Patch: use iccInfoPriv.spnDisplayCondition to store display condition
Attachment #749126 - Attachment is obsolete: true
Attachment #749126 - Flags: review?(allstars.chh)
Attachment #749186 - Flags: review?(allstars.chh)
Created attachment 749723 [details] [diff] [review]
Patch: use iccInfoPriv.spnDisplayCondition to store display condition v3

fix xpcshell failure.
Attachment #749186 - Attachment is obsolete: true
Attachment #749186 - Flags: review?(allstars.chh)
Attachment #749723 - Flags: review?(allstars.chh)
Comment on attachment 749723 [details] [diff] [review]
Patch: use iccInfoPriv.spnDisplayCondition to store display condition v3

Review of attachment 749723 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +11219,3 @@
>            iccInfo.isDisplayNetworkNameRequired = true;
>          } else {
>            iccInfo.isDisplayNetworkNameRequired = false;

we could make this remove this if block by
iccInfo.isDisplayNetworkNameRequired = (displayCondition & 0x01) != 0;

also with & 0x2 below.

But it doesn't matter too much so I leave you to decide.
Attachment #749723 - Flags: review?(allstars.chh) → review+
Created attachment 750278 [details] [diff] [review]
Patch: use iccInfoPriv.spnDisplayCondition to store display condition (check in version)
Attachment #749723 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/7c9620071088
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox22: --- → wontfix
status-firefox23: --- → wontfix
status-firefox24: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.