849900 - remove hacks to enable mozbase from the automation code when we are running all tests in a virtualenv

Status: NEW

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 827446, we are hacking the sys.path and our import statements for our harnesses to use mozbase modules outside of a virtualenv.  We need to ensure that these hacks are removed when the tests are always run from a virtualenv.

Comment 1

[Jens Müller (:tessarakt)]

Is anything still blocking this?

I stumbled across the hack in mail/test/mozmill/runtest.py and saw that it deals with mozcrash. Bug 903616 is also about mozcrash, so I wonder whether there is a connection.

OR maybe automation.py requires the same hack somehow ...

Comment 2

[Jesse Ruderman]

My fuzz scripts will break if this hack is removed.  If I'm supposed to use virtualenv when calling automation.py (or its successor), I'll need help figuring out how to do that.

Comment 3

[(not currently active) Ted Mielczarek]

Our long-term goal is to neuter automation.py, and possibly remove it entirely. The replacement would be to use mozbase modules directly. The virtualenv requirement is mostly just to have the mozbase modules in the path. We could probably make a package out of what's left of automation.py with its own setup.py that you could run in a fresh virtualenv to get all the mozbase packages you need installed.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aa8d50067ec

Comment 5

[Chris Manchester (limited bugmail, email directly)]

This has caused significant confusion in the past, and I just noticed some test packaging cruft associated with it I want to get rid of.

Jesse, is this still a concern for you?

Comment 6

[Chris Manchester (limited bugmail, email directly)]

I doubt it would break anything to remove this now, but surprisingly it's still in tree: https://searchfox.org/mozilla-central/rev/fca0be7e2cf2f922c9b927423ce28e8a04b3fd90/testing/xpcshell/runxpcshelltests.py#64