BaselineCompiler: Fix ARM crash on Box2D, CodeLoad, and GameBoy

RESOLVED FIXED

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: djvj, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
AWFY ARM has these octane benches crashing.
(Reporter)

Comment 1

6 years ago
Created attachment 723638 [details] [diff] [review]
Patch

Issue was branch32(Condition, Operand, Register, Label) and branch32(Condition, Operand, Imm32, Label).

Both used ma_ldr to load the Operand into a register before doing the cmp32.  However, Operand can also be a plain register.  This modifies branch32 to handle that case efficiently.
Attachment #723638 - Flags: review?(mrosenberg)
Attachment #723638 - Flags: review?(mrosenberg) → review+
(Reporter)

Comment 2

6 years ago
Pushed, waiting for tbpl green to close:
https://hg.mozilla.org/projects/ionmonkey/rev/4283f40d30ab

Comment 3

6 years ago
Time to close?
(Reporter)

Comment 4

6 years ago
Yes.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.