Closed Bug 849909 Opened 10 years ago Closed 10 years ago

BaselineCompiler: Fix ARM crash on Box2D, CodeLoad, and GameBoy

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: djvj, Unassigned)

References

Details

Attachments

(1 file)

AWFY ARM has these octane benches crashing.
Attached patch PatchSplinter Review
Issue was branch32(Condition, Operand, Register, Label) and branch32(Condition, Operand, Imm32, Label).

Both used ma_ldr to load the Operand into a register before doing the cmp32.  However, Operand can also be a plain register.  This modifies branch32 to handle that case efficiently.
Attachment #723638 - Flags: review?(mrosenberg)
Attachment #723638 - Flags: review?(mrosenberg) → review+
Pushed, waiting for tbpl green to close:
https://hg.mozilla.org/projects/ionmonkey/rev/4283f40d30ab
Time to close?
Yes.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.