849961 - Make nsWindow::DispatchMultitouchEvent honor event.mFlags.mMultipleActionsPrevented

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jonathan Watt [:jwatt]]

nsWindow::DispatchMultitouchEvent needs to honor event.mFlags.mMultipleActionsPrevented or else we can't prevent scrolling _and_ still have elements take focus when an element is dragged. E.g. see bug 849552.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 723622 [details] [diff] [review]
patch

Review of attachment 723622 [details] [diff] [review]:
-----------------------------------------------------------------

I think from the android-widget side, this is fine.

::: widget/android/nsWindow.cpp
@@ +1290,5 @@
>      }
>  
>      nsEventStatus status;
>      DispatchEvent(&event, status);
> +    return (status == nsEventStatus_eConsumeNoDefault ||

Lets add a comment explaining that we're using mMultipleActionsPrevented to handle cases where we want to prevent panning, but not prevent focus events.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e993ef95ad7

(In reply to Wesley Johnston (:wesj) from comment #2)
> Lets add a comment explaining that we're using mMultipleActionsPrevented to
> handle cases where we want to prevent panning, but not prevent focus events.

Comment added.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e993ef95ad7