Closed Bug 850072 Opened 7 years ago Closed 7 years ago

JavaScript error in pageInfo.js with broken image

Categories

(SeaMonkey :: Page Info, defect)

defect
Not set

Tracking

(seamonkey2.16 affected, seamonkey2.17 fixed, seamonkey2.18 fixed, seamonkey2.19 fixed)

RESOLVED FIXED
seamonkey2.19
Tracking Status
seamonkey2.16 --- affected
seamonkey2.17 --- fixed
seamonkey2.18 --- fixed
seamonkey2.19 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Bug 504041 made it necessary for bug 811904 to change its animated image detection. However the new code sometimes throws exceptions for broken images. It seems to be "OK" for broken data: "images" but not broken http: "images".

Steps to reproduce problem:
1. Load a page that contains a broken image
2. Find the image in Page Info
3. Note that the image properties do not update when the image is selected
Attached patch Proposed patchSplinter Review
The documentation for the animated property says that it might throw if the decode isn't complete, thus the extra check.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #723722 - Flags: review?(philip.chee)
Comment on attachment 723722 [details] [diff] [review]
Proposed patch

Tested with data:text/html,<img src=http://doesnotexist.local/><img src=about:logo><img src=data:,>

r=me
Attachment #723722 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset ce090c5eb94b.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 723722 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 811904
User impact if declined: Page info image tab does not update correctly
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #723722 - Flags: approval-comm-beta?
Attachment #723722 - Flags: approval-comm-aurora?
Attachment #723722 - Flags: approval-comm-beta?
Attachment #723722 - Flags: approval-comm-beta+
Attachment #723722 - Flags: approval-comm-aurora?
Attachment #723722 - Flags: approval-comm-aurora+
Target Milestone: --- → seamonkey2.19
You need to log in before you can comment on or make changes to this bug.