850072 - JavaScript error in pageInfo.js with broken image

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[[e-mail]]

Bug 504041 made it necessary for bug 811904 to change its animated image detection. However the new code sometimes throws exceptions for broken images. It seems to be "OK" for broken data: "images" but not broken http: "images".

Steps to reproduce problem:
1. Load a page that contains a broken image
2. Find the image in Page Info
3. Note that the image properties do not update when the image is selected

Comment 1

[[e-mail]]

Attachment: Proposed patch

The documentation for the animated property says that it might throw if the decode isn't complete, thus the extra check.

Comment 2

[Philip Chee]

Comment on attachment 723722 [details] [diff] [review]
Proposed patch

Tested with data:text/html,<img src=http://doesnotexist.local/><img src=about:logo><img src=data:,>

r=me

Comment 3

[[e-mail]]

Pushed comm-central changeset ce090c5eb94b.

Comment 4

[[e-mail]]

Comment on attachment 723722 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 811904
User impact if declined: Page info image tab does not update correctly
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 5

[Philip Chee]

Pushed to branches:
http://hg.mozilla.org/releases/comm-aurora/rev/f28e11fb00de
http://hg.mozilla.org/releases/comm-beta/rev/58816ab28194