Closed Bug 850132 Opened 7 years ago Closed 7 years ago

SPS breakpad unwind (bug 779291) breaks Win64 builds with "Unsupported platform"

Categories

(Core :: Gecko Profiler, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: philor, Assigned: m_kato)

References

Details

(Keywords: regression)

Attachments

(1 file)

There is a certain amount of truth to that error message, but it's not quite entirely true.

https://tbpl.mozilla.org/php/getParsedLog.php?id=20544174&tree=Firefox
https://tbpl.mozilla.org/php/getParsedLog.php?id=20544370&tree=Firefox

e:\builds\moz2_slave\m-cen-w64-00000000000000000000\build\tools\profiler\PlatformMacros.h(67) : fatal error C1189: #error : "Unsupported platform"
Assignee: nobody → m_kato
Hardware: x86 → x86_64
Attached patch fixSplinter Review
fix windows x64 build.  also android macro should use __ANDROID__ that is pre-defined by compiler (gcc and clang).
Attachment #723831 - Flags: review?(ted)
Comment on attachment 723831 [details] [diff] [review]
fix

Review of attachment 723831 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really a peer on this code, but this looks ok to me. As long as it builds it should be fine. Note that bug 779291 has been backed out for now, so we'll have to land this on top of it (or fold it into the re-landing).
Attachment #723831 - Flags: review?(ted) → review+
I folded this into the original patch and re-landed that:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b366545161d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.