850217 - Regression: Screen artifacts on search suggestion acceptance animation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/12) - Screenshot

See screenshot

I have seen this on a variety of phones tested thus far

* Samsung Galaxy Note 
* Samsung Galaxy Note II
* Sony Xperia Play
* Samsung Galaxy SII
* Samsung Galaxy Nexus

--
Nightly (03/12)

Comment 1

[Aaron Train [:aaronmt]]

See this on pretty much every device, as the thing slides off when you accept suggestions - some devices the text leaves artifacts, on others I get a black flash on the screen.

Comment 2

[Aaron Train [:aaronmt]]

On today's Nightly it's animated with a black bar for me on my Nexus 4

http://www.youtube.com/watch?v=c84u8kwMO6w

Comment 3

[Aaron Train [:aaronmt]]

My mistake, not the dynamic-toolbar

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7632ab657e5&tochange=b0e08db3bc2a

In particular http://hg.mozilla.org/mozilla-central/diff/29de190ac31c/mobile/android/base/resources/layout/awesomebar_suggestion_prompt.xml

Comment 4

[Aaron Train [:aaronmt]]

Happy to try a build with that backed out for confirmation

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The background stays - no corruption
The content has a transparent container - no overdraw
WIN! WIN!

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e04bd7ba837

Comment 7

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/1e04bd7ba837

Comment 8

[Aaron Train [:aaronmt]]

This wasn't tested and is still busted.

http://cl.ly/image/0y3L2t3G2T3W

Comment 9

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/27) - Galaxy Note II

Comment 10

[Aaron Train [:aaronmt]]

Still see this on 04/02 Nightly

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

need a new patch

Comment 12

[Aaron Train [:aaronmt]]

Still an issue, 04/27.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Lucas - Take a look?

Comment 14

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch 2: Screen artifact

setAnimation() sets the next animation to be carried out on a view, but doesnt start it.
We set a sliding animation for the text+button. But we slide the entire layout (with the background). This caused the artifact.

This patch slides the text+button to the right, and slides the list view and outer container (with blue color) to the top.

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 747536 [details] [diff] [review]
Patch 2: Screen artifact

Will this uplift to Fx22 (Aurora) ? If not, can you rebase for Aurora?

Comment 16

[Sriram Ramasubramanian [:sriram]]

This will uplift to Fx22 without a need for rebasing.
This was tested in Nexus 4 too (that ugly graphics phone!)
https://hg.mozilla.org/integration/mozilla-inbound/rev/db1de122b262

Comment 17

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 747536 [details] [diff] [review]
Patch 2: Screen artifact

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Overdraw removal on awesomescreen.
User impact if declined: Artifacts on the search suggestion selection.
Testing completed (on m-c, etc.): Landed in m-i on 05/09.
Risk to taking this patch (and alternatives if risky): None. Proper animations are done now.
String or IDL/UUID changes made by this patch: None.

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/db1de122b262

Comment 19

[Aaron Train [:aaronmt]]

\o/

Comment 20

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b6d132db5e2b

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
-build: Firefox for Android 22 Beta 2
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1