Closed Bug 850458 Opened 7 years ago Closed 7 years ago

work - add full screen video element to html5 video controls

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

All
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: jbecerra, Assigned: bbondy)

References

Details

(Whiteboard: feature=work)

Attachments

(2 files)

Tested on 2013-03-12 on nightly built from http://hg.mozilla.org/mozilla-central/rev/7433bc4545c9

While regression testing 801183, I found myself wanting a fullscreen video control in the html5 video I tried.

Steps:
1. Go to http://clips.vorwaerts-gmbh.de/big_buck_bunny.ogv
2. Try to fullscreen the video

Expected: Some control to fullscreen the video playback

Actual: No such control element.
Priority: -- → P2
Whiteboard: feature=work
Whiteboard: feature=work → feature=work DUPEME
Priority: P2 → P3
It is important to get full screen for HTML video in these controls because we won't have Flash support and the video tag is going to be the primary video experience on Metro.  Also, is this bug materially different from bug 842130?

Jared, any change you have some cycles to help us with this?
Blocks: 842639
No longer blocks: metrov1triage
Priority: P3 → P2
Hardware: x86_64 → All
Whiteboard: feature=work DUPEME → feature=work
Flags: needinfo?(jAwS)
Should we make the html5 video control the same as Desktop Firefox?
OS: Windows 8 → Windows 8 Metro
(In reply to Brian R. Bondy [:bbondy] from comment #2)
> Should we make the html5 video control the same as Desktop Firefox?

I haven't gotten the chance to look yet (it's on my todo list), but I think metro uses mobile's video controls. Mobile and desktop should have a fullscreen button already in the video controls, so something must not be showing it.

I'll try to look into this later today.
Flags: needinfo?(jAwS)
Flags: needinfo?(jAwS)
(In reply to Brian R. Bondy [:bbondy] from comment #2)
> Should we make the html5 video control the same as Desktop Firefox?

Are our desktop controls touch friendly? If so, let's use them. If not, let's figure out how to augment what we have that is touch friendly.
Probably not 'as' touch friendly. OK.
(In reply to Brian R. Bondy [:bbondy] from comment #6)
> Created attachment 730349 [details]
> Screenshot of Metro video controls

Thanks! I was just firing up my VM. Those are the touch controls, designed to be touch-friendly.

Ok, this is the problem here:
http://mxr.mozilla.org/mozilla-central/source/browser/metro/theme/touchcontrols.css#56

You can see what b2g did: http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/touchcontrols.css#30

B2G has graphics for it, but they might be slightly different (they are newer though).
Flags: needinfo?(jAwS)
BTW, I don't think I'll have time to help with fixing this bug. Hopefully comment #7 is enough of a guide though. I'll try to respond to questions though.
Thanks for the info Jared!
Duplicate of this bug: 842130
Attached patch Patch v1.Splinter Review
Basically as per your suggestions in the other dupe bug and Jared's suggestion here I just made the css consistent with B2G and everything worked.
Assignee: nobody → netzen
Attachment #730863 - Flags: review?(mbrubeck)
*and added the 2 missing images and modified the image paths but that's it.
Comment on attachment 730863 [details] [diff] [review]
Patch v1.

I'm also following bug 704229 which should allow us to share all this code with Fennec and B2G.
Attachment #730863 - Flags: review?(mbrubeck) → review+
We still have all the xul fennec fullscreen code sitting in the repo. Deciding what to do with that was bug 842130. If we're going to dupe over, we'll need to figure out what we plan to do with all of this code here.

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/video.js
http://mxr.mozilla.org/mozilla-central/source/browser/metro/modules/video.jsm
http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/pages/fullscreen-video.xhtml
OK I'll re-open it for that.
Backout for potential bustage (on some slaves but not others :S)
https://hg.mozilla.org/integration/mozilla-inbound/rev/088d73e55949
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b35998de0fe
Target Milestone: Firefox 22 → Firefox 23
https://hg.mozilla.org/mozilla-central/rev/8b35998de0fe
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.