Create some mochitests for verifying that onXXX handlers fire at the correct time with Data Channels

RESOLVED FIXED

Status

()

P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jsmith, Assigned: whimboo)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][tests][will be fixed with bug 796895])

(Reporter)

Description

6 years ago
Create some mochitests that verify that the onXXX handlers with Data Channels fire at the time we expect them to fire. Such onXXX handlers you'll want to analyze includes:

- onopen
- onerror
- onclose
- onmessage
(Reporter)

Updated

6 years ago
Blocks: 767072
(Reporter)

Comment 1

6 years ago
Important cause we need at least one test that makes sure events fire at the *right* time. Into the ? pool for blocking analysis.
Priority: -- → P2
Whiteboard: [WebRTC][blocking-webrtc?]
(Assignee)

Comment 2

6 years ago
All of those events will be covered by my first data connection test which will most likely be bug 796895 (if I hit no other road blockers).
Depends on: 796895
Whiteboard: [WebRTC][blocking-webrtc?] → [WebRTC][blocking-webrtc?][will be fixed with bug 796895]
(Reporter)

Comment 3

6 years ago
Sounds like this should block if bug 796895 blocks then. Although fixing one will fix the other.
Whiteboard: [WebRTC][blocking-webrtc?][will be fixed with bug 796895] → [WebRTC][blocking-webrtc+][will be fixed with bug 796895]
(Reporter)

Comment 4

6 years ago
Since whimboo is working on the other bug, I'm going to set you as the assignee working on this one as well by caveat.
Assignee: nobody → hskupin
(Reporter)

Updated

6 years ago
Whiteboard: [WebRTC][blocking-webrtc+][will be fixed with bug 796895] → [WebRTC][blocking-webrtc-][tests][will be fixed with bug 796895]
(Reporter)

Comment 5

5 years ago
bug 796894 fixes most of these cases, except the onerror case.
Depends on: 796894
No longer depends on: 796895
(Reporter)

Comment 6

5 years ago
(In reply to Jason Smith [:jsmith] from comment #5)
> bug 796894 fixes most of these cases, except the onerror case.

Turns out we injected checks for onerror as well, although for the case of when we shouldn't expect it to fire. However, that covers enough of this to call this fixed by bug 796894. If there are specific cases we haven't covered yet, then let's file specific bugs for those cases.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.