850489 - Settings page background switches between blue and white on Nexus S

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

This seems like a regression from bug 846396.

Comment 1

[Aaron Train [:aaronmt]]

Saw this today too testing a bunch of Gingerbread Alcatel phones

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This removes the cache color hint for settings screen. That way the list view won't have a problem (tested it on a Nexus S).

Comment 3

[Wesley Johnston (:wesj)]

Why can't we set the cache color hint to the right thing (@color/background_normal)?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 732557 [details] [diff] [review]
Patch

Waiting for a reply to Wes' question before r+

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

That works.

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfabb78fc101

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfabb78fc101

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 736546 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Strange flashing
Testing completed (on m-c, etc.): Landed and works
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

regressed by bug 846396, which is on aurora

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This doesn't apply cleanly to Aurora. Please provide a rebased patch or uplift yourself.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)
> This doesn't apply cleanly to Aurora. Please provide a rebased patch or
> uplift yourself.

Brian - Can you handle this since Sriram is PTO?

Comment 13

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1518010c36e5

Comment 14

[Brian Nicholson (:bnicholson)]

I don't see this issue on beta.