850558 - The stack trace breadcrumbs context menu is ugly on windows.

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P3)

Description

[Girish Sharma [:Optimizer]]

Attachment: ugly context menu.

The padding, boldness and border is missing.

Comment 1

[Girish Sharma [:Optimizer]]

Well, it is bold, but the difference is hard to see.

Comment 2

[Joshua Smith [:joshua-s]]

I would like to take this!

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Joshua Smith [:joshua-s] from comment #2)
> I would like to take this!

That's wonderful, thanks!

Comment 4

[Joshua Smith [:joshua-s]]

Oh no, this bug is in Windows 7.

I only have XP and Mac, so it doesn't show the issue.  Sorry guys :(

Comment 5

[MikeLing]

Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.

Comment 6

[Girish Sharma [:Optimizer]]

(In reply to MikeLing from comment #5)
> Hi I am interested in working on this bug,but it's my first time to work on
> with debug,can anybody guide me on how to get started with it?Thanks a lot.

Continuing and replying to what you were asking on IRC:

You cannot use Linux/Ubuntu to fix this bug as the issue is seen only on Windows 7 (Vista may be too). So I guess you will have to use Visual Studio and all those stuff instead of your VM box :).

And thus , I think you already are aware of how to build a basic Firefox build. 

On how to solve the issue :

This will need mostly CSS changes in browser/themes/windows/devtools/debugger.css file.

See http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/devtools/debugger.css#45

That is the point where the menu item CSS starts.

Please ping me on IRC for further help. My nick is Optimizer.

Comment 7

[MikeLing]

(In reply to Girish Sharma [:Optimizer] from comment #6)
> (In reply to MikeLing from comment #5)
> > Hi I am interested in working on this bug,but it's my first time to work on
> > with debug,can anybody guide me on how to get started with it?Thanks a lot.
> 
> Continuing and replying to what you were asking on IRC:
> 
> You cannot use Linux/Ubuntu to fix this bug as the issue is seen only on
> Windows 7 (Vista may be too). So I guess you will have to use Visual Studio
> and all those stuff instead of your VM box :).
> 
> And thus , I think you already are aware of how to build a basic Firefox
> build. 
> 
> On how to solve the issue :
> 
> This will need mostly CSS changes in
> browser/themes/windows/devtools/debugger.css file.
> 
> See
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/
> devtools/debugger.css#45
> 
> That is the point where the menu item CSS starts.
> 
> Please ping me on IRC for further help. My nick is Optimizer.

I am so appreciate about you can help and my system is window 7 actually :) .I promise I will fix the issue as soon as possible.Thanks again

Comment 8

[Girish Sharma [:Optimizer]]

Cool, assigned to you. Thank you for taking it.

Comment 9

[MikeLing]

(In reply to Girish Sharma [:Optimizer] from comment #8)
> Cool, assigned to you. Thank you for taking it.
Sorry to distrub you,but I find a problem when a build source code
--------------------------------------------------------------------------------------
$ python make.py
Traceback (most recent call last):
  File "make.py", line 10, in <module>
    import pymake.command, pymake.process
  File "d:\mozilla-source\mozilla-central\build\pymake\pymake\command.py", line
14, in <module>
    import data, parserdata, process, util
  File "d:\mozilla-source\mozilla-central\build\pymake\pymake\data.py", line 6,
in <module>
    import parserdata, parser, functions, process, util, implicit
  File "d:\mozilla-source\mozilla-central\build\pymake\pymake\process.py", line
7, in <module>
    import multiprocessing
  File "D:\Python27\Lib\multiprocessing\__init__.py", line 84, in <module>
    import _multiprocessing
ImportError: DLL load failed:%1 is not a valid Win32 application
--------------------------------------------------------------------------------------
but I'm sure I put the python to my PATH(my PATH was blow) what should I do?
--------------------------------------------------------------------------------------
C:\mozilla-build\python;D:\Python32\python;D:\Python27;C:\mozilla-build\svn-win32-1.6.3\bin;C:\mozilla-build\wget;C:\mozilla-build\7zip\Codecs

Comment 10

[Girish Sharma [:Optimizer]]

On windows, you do not use the make.py directly. Please see the steps here :https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

make sure you have all the prerequisites : https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites

Comment 11

[Girish Sharma [:Optimizer]]

Hi MikeLing, were you able to make any progress on this bug ? Please let me know how I can help you. If you are not working on this bug, then we can free up this bug for other contributors :)

Comment 12

[MikeLing]

(In reply to Girish Sharma [:Optimizer] from comment #11)

 Please free up this bug for other contributors,Thanks a lot :)

Comment 13

[Victor Porof [:vporof][:vp]]

I'm removing the context menu in bug 905981.

Comment 14

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Is this still true after the recent theming work? Can we close this bug?