850639 - the dependency graph should have an upper limit on the number of nodes it attempts to graph

Status: RESOLVED FIXED

(Bugzilla :: Dependency Views, enhancement)

Description

[:glob ✱]

on bugzilla.mozilla.org the load on one of our webheads was high for 8+ hours, which we tracked down to a dependency graph (dot process) with 354364 nodes.

we should hard code an upper limit on the number of things we try to graph.
i'm thinking about the 500 mark.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[Frédéric Buclin]

Comment on attachment 725279 [details] [diff] [review]
patch v1

>=== modified file 'showdependencygraph.cgi'

>     } else {
>         print $fh "$k\n";
>     }
>+    $node_count++;

This line must go away. We are not adding a new node but only data about existing bugs themselves.


>=== modified file 'template/en/default/global/user-error.html.tmpl'

>+  [% ELSIF error == "webdot_too_large" %]
>+    [% title = "Dependancy Graph Too Large" %]
>+    The dependancy graph contains too many nodes to display.

You should say "bugs" instead of "nodes". Most people won't understand what these nodes are. Also, displaying the max value allowed could help.

Comment 3

[:glob ✱]

Attachment: patch v2

updated.  also increased the limit from 1000 to 2000 based on feedback from simon@redhat.

Comment 4

[Frédéric Buclin]

Comment on attachment 729983 [details] [diff] [review]
patch v2

>=== modified file 'template/en/default/global/user-error.html.tmpl'

>+    [% title = "Dependancy Graph Too Large" %]
>+    The dependancy graph contains too many [% terms.bugs %] to display (more

s/dependancy/dependency/i


r=LpSolit

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified showdependencygraph.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 8600.

Comment 6

[:glob ✱]

fix for the "Use of uninitialized value" warning for bugs without dependencies:

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified showdependencygraph.cgi
Committed revision 8601.