the dependency graph should have an upper limit on the number of nodes it attempts to graph

RESOLVED FIXED in Bugzilla 5.0

Status

()

--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Bugzilla 5.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
on bugzilla.mozilla.org the load on one of our webheads was high for 8+ hours, which we tracked down to a dependency graph (dot process) with 354364 nodes.

we should hard code an upper limit on the number of things we try to graph.
i'm thinking about the 500 mark.

Updated

6 years ago
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 1

6 years ago
Created attachment 725279 [details] [diff] [review]
patch v1
Assignee: dependency.views → glob
Status: NEW → ASSIGNED
Attachment #725279 - Flags: review?(LpSolit)

Comment 2

6 years ago
Comment on attachment 725279 [details] [diff] [review]
patch v1

>=== modified file 'showdependencygraph.cgi'

>     } else {
>         print $fh "$k\n";
>     }
>+    $node_count++;

This line must go away. We are not adding a new node but only data about existing bugs themselves.


>=== modified file 'template/en/default/global/user-error.html.tmpl'

>+  [% ELSIF error == "webdot_too_large" %]
>+    [% title = "Dependancy Graph Too Large" %]
>+    The dependancy graph contains too many nodes to display.

You should say "bugs" instead of "nodes". Most people won't understand what these nodes are. Also, displaying the max value allowed could help.
Attachment #725279 - Flags: review?(LpSolit) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 729983 [details] [diff] [review]
patch v2

updated.  also increased the limit from 1000 to 2000 based on feedback from simon@redhat.
Attachment #725279 - Attachment is obsolete: true
Attachment #729983 - Flags: review?(LpSolit)

Comment 4

6 years ago
Comment on attachment 729983 [details] [diff] [review]
patch v2

>=== modified file 'template/en/default/global/user-error.html.tmpl'

>+    [% title = "Dependancy Graph Too Large" %]
>+    The dependancy graph contains too many [% terms.bugs %] to display (more

s/dependancy/dependency/i


r=LpSolit
Attachment #729983 - Flags: review?(LpSolit) → review+

Updated

6 years ago
Flags: approval+
Target Milestone: --- → Bugzilla 5.0
(Assignee)

Comment 5

6 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified showdependencygraph.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 8600.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

6 years ago
fix for the "Use of uninitialized value" warning for bugs without dependencies:

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified showdependencygraph.cgi
Committed revision 8601.
You need to log in before you can comment on or make changes to this bug.