Closed Bug 850789 Opened 7 years ago Closed 7 years ago

[Tablet] - Hide tab sidebar when dynamic toolbar is off screen

Categories

(Firefox for Android :: General, defect)

22 Branch
ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 22
Tracking Status
firefox22 --- fixed
fennec 22+ ---

People

(Reporter: aaronmt, Assigned: cwiiis)

References

Details

(Keywords: regression, reproducible)

Attachments

(2 files)

See screenshot.

There's no way to close the sidebar unless the toolbar is revealed.

--
Nightly (03/13)
Asus Transformer TF201 (Android 4.1)
We should probably lock the header in place when the sidebar is opened. ibarlow?
Makes sense for now. 

Although once we add the ability to pin the sidebar open (bug 817728), perhaps we could let the title bar scroll off if the sidebar has been pinned.
Assignee: nobody → chrislord.net
tracking-fennec: ? → 22+
Attachment #725529 - Flags: review?(bugmail.mozilla)
Comment on attachment 725529 [details] [diff] [review]
Pin the toolbar when the tabs tray is open

Review of attachment 725529 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, but it's getting a bit confusing to have both mToolbarLocked and mToolbarPinned which do different things but sound similar. Maybe comment those variables so that it's clearer what they're for?
Attachment #725529 - Flags: review?(bugmail.mozilla) → review+
Comments for all variables added and pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c90398761b18
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c90398761b18
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Keywords: regression
Version: Trunk → Firefox 22
You need to log in before you can comment on or make changes to this bug.