[Tablet] - Hide tab sidebar when dynamic toolbar is off screen

RESOLVED FIXED in Firefox 22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: cwiiis)

Tracking

({regression, reproducible})

22 Branch
Firefox 22
ARM
Android
regression, reproducible
Points:
---

Firefox Tracking Flags

(firefox22 fixed, fennec22+)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 724531 [details]
Nightly (03/13) - Screenshot

See screenshot.

There's no way to close the sidebar unless the toolbar is revealed.

--
Nightly (03/13)
Asus Transformer TF201 (Android 4.1)
(Assignee)

Comment 1

6 years ago
We should probably lock the header in place when the sidebar is opened. ibarlow?
Makes sense for now. 

Although once we add the ability to pin the sidebar open (bug 817728), perhaps we could let the title bar scroll off if the sidebar has been pinned.
Assignee: nobody → chrislord.net
tracking-fennec: ? → 22+
(Assignee)

Comment 3

6 years ago
Created attachment 725529 [details] [diff] [review]
Pin the toolbar when the tabs tray is open
Attachment #725529 - Flags: review?(bugmail.mozilla)
Comment on attachment 725529 [details] [diff] [review]
Pin the toolbar when the tabs tray is open

Review of attachment 725529 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, but it's getting a bit confusing to have both mToolbarLocked and mToolbarPinned which do different things but sound similar. Maybe comment those variables so that it's clearer what they're for?
Attachment #725529 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 5

6 years ago
Comments for all variables added and pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c90398761b18
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c90398761b18
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22

Updated

6 years ago
status-firefox22: affected → fixed
Keywords: regression
Version: Trunk → Firefox 22
You need to log in before you can comment on or make changes to this bug.