850789 - [Tablet] - Hide tab sidebar when dynamic toolbar is off screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/13) - Screenshot

See screenshot.

There's no way to close the sidebar unless the toolbar is revealed.

--
Nightly (03/13)
Asus Transformer TF201 (Android 4.1)

Comment 1

[Chris Lord [:cwiiis]]

We should probably lock the header in place when the sidebar is opened. ibarlow?

Comment 2

[Ian Barlow (:ibarlow)]

Makes sense for now. 

Although once we add the ability to pin the sidebar open (bug 817728), perhaps we could let the title bar scroll off if the sidebar has been pinned.

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Pin the toolbar when the tabs tray is open

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 725529 [details] [diff] [review]
Pin the toolbar when the tabs tray is open

Review of attachment 725529 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, but it's getting a bit confusing to have both mToolbarLocked and mToolbarPinned which do different things but sound similar. Maybe comment those variables so that it's clearer what they're for?

Comment 5

[Chris Lord [:cwiiis]]

Comments for all variables added and pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c90398761b18

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c90398761b18