Closed Bug 850946 Opened 7 years ago Closed 7 years ago
Dark holo theme with Sync UI on Nexus 7/TF201
For whatever reason the Sync UI on the Nexus 7 (Android 4.2.2) is using a dark holo theme, but the same Android version (stock Android) on my Nexus 4 (Android 4.2.2) is using the light holo theme. What? See screenshot. -- Nexus 7 (Android 4.2.2) Nightly (03/13)
This is also an issue on Firefox Mobile 21 beta 1 on the Samsung Galaxy Nexus (Android 4.1.1) - although the button Nexus is visible - on the Asus EEE Transformer TF101 (Android 4.0.4) and Samsung Galaxy Tab 2 (Android 4.1.1)
Setting fx21 as affected based on comment 1 Sriram - What do we need to do to fix this?
The Dialog is using a Holo (Dark) theme. The title on top uses a pre-defined style that takes care of Holo theme. However, the bottom button uses a Holo.Light theme. Is there a reason for this?
Flags: needinfo?(sriram) → needinfo?(nalexander)
These are using Gecko.Dialog as their theme: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/themes.xml#13 We need to update that to inherit from something like Theme.Holo.Light.Dialog? or maybe better Theme.Light.Panel?
(In reply to Wesley Johnston (:wesj) from comment #4) > These are using Gecko.Dialog as their theme: > > http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/ > values/themes.xml#13 > > We need to update that to inherit from something like > Theme.Holo.Light.Dialog? or maybe better Theme.Light.Panel? I saw that too. But then, the dialogs ok. The title has a blue line as intented and hence didn't comment about it.
Attachment #732462 - Flags: review?
Had to hack to make us use this style on a phone, but works.
(In reply to Wesley Johnston (:wesj) from comment #6) > Created attachment 732462 [details] [diff] [review] > Patch > > Simple fix I believe this should done in Sync's git clone and then moved in here. Doing directly in central is not something that Sync likes (am I right?)
(In reply to Sriram Ramasubramanian [:sriram] from comment #8) > (In reply to Wesley Johnston (:wesj) from comment #6) > > Created attachment 732462 [details] [diff] [review] > > Patch > > > > Simple fix > > I believe this should done in Sync's git clone and then moved in here. Doing > directly in central is not something that Sync likes (am I right?) You are correct. I will take a look and test this fix this afternoon.
Thanks for thinking of Sync, sriram, but in this case Fennec owns values/themes.xml and values-v11/themes.xml. And this looks sensible to me, but I don't have a device to test on. I've pushed https://github.com/mozilla-services/android-sync/commit/a3afbf1124d534217cfd50e2fe65a5f64176a950 to harmonize Android Sync's non-authoritative copies of themes.xml with Fennec's, including this change. So please land it soon, so I don't have to roll back :)
Comment on attachment 732462 [details] [diff] [review] Patch Adding a reviewer. Nick wants this reviewed and landed soon :)
Attachment #732462 - Flags: review? → review?(sriram)
Attachment #732462 - Flags: review?(sriram) → review+
This is ready to land on trunk.
Unbitrotted and landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d30583cd42
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
TF201 affected along with other Acer Tablets running ICS. Any chance to get this uplifted?
This is also an issue on the Asus EEE Transformer TF101 (Android 4.0.4) and the Samsung Galaxy Tab 2 (Android 4.1.1) on Firefox Mobile 22 beta 3
You need to log in before you can comment on or make changes to this bug.