B2G Emulator: Add LTE signal report function.

RESOLVED FIXED in Firefox OS v1.4

Status

Firefox OS
Emulator
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: kenkai, Assigned: sku)

Tracking

(Blocks: 1 bug)

unspecified
1.4 S2 (28feb)
x86_64
Linux

Firefox Tracking Flags

(b2g-v1.4 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Current emulator can only send the GSM signal. We should add LTE signal report function for future LTE project.
Component: DOM → Emulator
Product: Core → Boot2Gecko
(Assignee)

Comment 1

4 years ago
Created attachment 8380515 [details] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function.
(Assignee)

Updated

4 years ago
Assignee: nobody → sku
(Assignee)

Comment 2

4 years ago
Comment on attachment 8380515 [details] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function.

1. Add LTE signal strength (ie: rxlev, rsrp and rssnr) on emulator.
2. Fix range check for rssi/ber at handleSignalStrength@android_modem.c

"gsm lte_signal <rxlev> <rsrp> <rssnr>" can be used to simulate the
LTE siganl strength on emulator with this patch.
Attachment #8380515 - Flags: review?(vyang)
Comment on attachment 8380515 [details] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function.

Have commented on Github.
Attachment #8380515 - Flags: review?(vyang)
(Assignee)

Comment 4

4 years ago
Created attachment 8381932 [details] [diff] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function. v2.

Test case is not available currently.
Reason:
  ril_worker.js will only handle rssi, and map it to 0 ~ 100. it did not handle rxlev/rsrp/rssnr. Hence, there will not take any effect if we trigger "gsm lte_signal <rxlev> <rsrp> <rssnr>".

I will file a new bug for supporting LTE signal on Gecko (plus test cases) later.


// Major Change:
1. Add LTE signal strength (ie: rxlev, rsrp and rssnr) on emulator.
2. Fix range check for rssi/ber at handleSignalStrength@android_modem.c.
3. print rssi/ber if no argument for "gsm signal" command,
   print rxlev/rsrp/rssnr if no argument for "gsm lte_signal" command.

Ex:
1. "gsm signal" will print the current rssi/ber on console.
2. "gsm lte_signal" will print the current rxlev/rsrp/rssnr on console.
3. "gsm lte_signal <rxlev> <rsrp> <rssnr>" will be used to set the
   LTE siganl strength on emulator, and report RIL_UNSOL_SIGNAL_STRENGTH
   to upper layer.
(Assignee)

Updated

4 years ago
Attachment #8380515 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Attachment #8381932 - Attachment is patch: true
Attachment #8381932 - Attachment mime type: text/x-github-pull-request → text/plain
(Assignee)

Updated

4 years ago
Attachment #8381932 - Flags: review?(vyang)
Attachment #8381932 - Flags: review?(vyang) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 8382695 [details] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function. r=vicamo.
Attachment #8381932 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

4 years ago
Bug 977433 is created for supporting LTE signal strength in ril_worker.js (Gecko side).
Master: 456499c44d1ef39b602ea02e9ed460b6aab85b44
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v1.4: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in before you can comment on or make changes to this bug.