850996 - B2G Emulator: Add LTE signal report function.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Ken Chang[:kenkai]]

Current emulator can only send the GSM signal. We should add LTE signal report function for future LTE project.

Comment 1

[shawn ku [:sku]]

Attachment: Bug 850996 - B2G Emulator: Add LTE signal report function.

Comment 2

[shawn ku [:sku]]

Comment on attachment 8380515 [details] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function.

1. Add LTE signal strength (ie: rxlev, rsrp and rssnr) on emulator.
2. Fix range check for rssi/ber at handleSignalStrength@android_modem.c

"gsm lte_signal <rxlev> <rsrp> <rssnr>" can be used to simulate the
LTE siganl strength on emulator with this patch.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8380515 [details] [review]
Bug 850996 - B2G Emulator: Add LTE signal report function.

Have commented on Github.

Comment 4

[shawn ku [:sku]]

Attachment: Bug 850996 - B2G Emulator: Add LTE signal report function. v2.

Test case is not available currently.
Reason:
  ril_worker.js will only handle rssi, and map it to 0 ~ 100. it did not handle rxlev/rsrp/rssnr. Hence, there will not take any effect if we trigger "gsm lte_signal <rxlev> <rsrp> <rssnr>".

I will file a new bug for supporting LTE signal on Gecko (plus test cases) later.


// Major Change:
1. Add LTE signal strength (ie: rxlev, rsrp and rssnr) on emulator.
2. Fix range check for rssi/ber at handleSignalStrength@android_modem.c.
3. print rssi/ber if no argument for "gsm signal" command,
   print rxlev/rsrp/rssnr if no argument for "gsm lte_signal" command.

Ex:
1. "gsm signal" will print the current rssi/ber on console.
2. "gsm lte_signal" will print the current rxlev/rsrp/rssnr on console.
3. "gsm lte_signal <rxlev> <rsrp> <rssnr>" will be used to set the
   LTE siganl strength on emulator, and report RIL_UNSOL_SIGNAL_STRENGTH
   to upper layer.

Comment 5

[shawn ku [:sku]]

Attachment: Bug 850996 - B2G Emulator: Add LTE signal report function. r=vicamo.

Comment 6

[shawn ku [:sku]]

Bug 977433 is created for supporting LTE signal strength in ril_worker.js (Gecko side).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: 456499c44d1ef39b602ea02e9ed460b6aab85b44