851031 - The Downloads button's position is changed after uninstalling Yandex

Status: RESOLVED WORKSFORME

(Firefox :: Downloads Panel, defect)

Description

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130313 Firefox/22.0
Build ID: 20130313031041

Steps to reproduce:
1. Launch Firefox with a new profile
2. Navigate to: http://element.yandex.com, install Yandex and restart Firefox
3. Click on the Downloads button 
4. Open the Downloads Manager uninstall Yandex (both Yandex Elements and Visual Bookmarks) and restart Firefox
5. Observe the position of the downloads button.

Expected results:
The button's position doesn't change after uninstalling Yandex.

Actual results:
The button is located between the URL bar and Search bar (per default the button is located in the URL bar after the Search bar).
Please see the screencast for more details: http://screencast.com/t/FcTR3Ll9Ibk

Note: 
The issue is reproducible also on the latest Aurora and Firefox 20 beta 5:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130313 Firefox/21.0,  Build ID: 20130313042013
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0, Build ID: 20130313170052

Comment 1

[Simona Badau, Desktop QA]

I can reproduce this issue on Firefox Nightly using Yandex  7.4.1 ever since August 26th:

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f077de66e52d&tochange=b3cce81fef1a

Comment 2

[Marco Bonardo [:mak]]

should be investigated, at first glance looks like the yandex add-on is doing "fancy" things to the toolbars. Mostly looks like it's removing the search bar, and then it's adding it back at the wrong place, in such a case we couldn't do anything our side.

Comment 3

[u279076]

Simona, could you try to narrow down the regression range further? There are 3 merges in the push log which makes it hard to pinpoint. It would also be worth investigating if there is a regression range correlated to Yandex versions. It's possible there is a joint regression.

Note, August 25 puts this in the Firefox 17 timeframe. Nominating for tracking all current branches since Yandex is a partner.

Comment 4

[Alex Keybl [:akeybl]]

Not critical enough to track, since the download panel is still fully functional and this will impact a very small subset of users (Yandex Elements, uninstall).

Comment 5

[Simona Badau, Desktop QA]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #3)
> Simona, could you try to narrow down the regression range further? There are
> 3 merges in the push log which makes it hard to pinpoint. 
The issue is first reproducible in: 
a86ecc9f22ad	Paolo Amadini — Bug 748381 - Update the behavior of the Downloads indicator. r=mano

It would also be
> worth investigating if there is a regression range correlated to Yandex
> versions. It's possible there is a joint regression.
I couldn't find older versions.

Comment 6

[Marco Bonardo [:mak]]

that bug adds the button to the defaultSet and runs migration ui if the feature is not disabled, it's going to be a mess just to try figuring out a regression in that patch, it would probably just be easier to investigate it as a new bug, it's indeed likely that patch only made visible an existing problem.

Comment 7

[Simona Badau, Desktop QA]

Closing this as Resolved Worksforme since this is not reproducible anymore using latest Firefox 123.0 build and any available Yandex extension that I could find on Firefox Add-ons - the Yandex elements mentioned in the Descriptions are no longer compatible to Firefox browser.