Last Comment Bug 851192 - Enable geo-location for marketplace
: Enable geo-location for marketplace
Status: RESOLVED FIXED
:
Product: Marketplace
Classification: Server Software
Component: General (show other bugs)
: 1.0
: All All
: P1 normal (vote)
: 2013-04-18
Assigned To: Wraithan (Chris McDonald) [:wraithan]
:
Mentors:
Depends on: 854734
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-14 10:47 PDT by Wil Clouser [:clouserw]
Modified: 2013-04-12 17:40 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Wil Clouser [:clouserw] 2013-03-14 10:47:18 PDT
Right now we determine what region you want to visit based on your language preferences.  We should do geo-location.

Apparently bug 774746 gave us geo-location, but I don't think those daemons were ever turned on.  CCing JR to give us the current status and we can pick up from there in this bug.
Comment 1 Wraithan (Chris McDonald) [:wraithan] 2013-03-25 13:02:14 PDT
Updates:

mkelly has written a geoip server that is more inline with how we'd like to run, as well as being benchmarked: https://github.com/mozilla/geodude

It is currently deployed at http://geo.mozilla.org/country.json to see how it works.

Due to the dataset that we are using, we can't send an arbitrary IP to the server and get back data if the server is public. I'll be forking and adding an endpoint that handles this case. This means we'll need to deploy into our own infrastructure behind the firewall.

I've spoken to cvan to see where in zamboni we need this added, and I'll be coding that up as well as fixing the server. 

Current ETA for the server fork being ready is 2 hours, then I'll be working with ops to get it deployed on a dev server.

Current ETA for the zamboni side is 1-2 hours, it will be behind a waffle so it can be landed and tested on -dev but not affect release this week if we don't have production geoip servers yet.
Comment 2 Wil Clouser [:clouserw] 2013-03-25 13:04:54 PDT
(In reply to Wraithan from comment #1)
> Due to the dataset that we are using, we can't send an arbitrary IP to the
> server and get back data if the server is public. I'll be forking and adding
> an endpoint that handles this case. This means we'll need to deploy into our
> own infrastructure behind the firewall.

Why would you fork instead of giving a patch to mkelly that has your endpoint behind a flag?
Comment 3 Wil Clouser [:clouserw] 2013-04-09 16:38:05 PDT
What's happening with this bug?
Comment 4 Wraithan (Chris McDonald) [:wraithan] 2013-04-12 16:22:46 PDT
https://github.com/mozilla/zamboni/commit/88656192eb05b560b04718422039df3cbfc6fac9

Code landed. waffle needs to be flipped and a setting added.
Comment 5 Wil Clouser [:clouserw] 2013-04-12 16:32:55 PDT
(In reply to Wraithan from comment #4)
> https://github.com/mozilla/zamboni/commit/
> 88656192eb05b560b04718422039df3cbfc6fac9
> 
> Code landed. waffle needs to be flipped and a setting added.

what waffle?  what setting?
Comment 6 Wraithan (Chris McDonald) [:wraithan] 2013-04-12 16:36:53 PDT
geoip-geodude is the waffle, the setting comment was more for me, I have a commit that adds them just waiting for r+, then I'll be done with this bug.
Comment 7 Wraithan (Chris McDonald) [:wraithan] 2013-04-12 16:45:46 PDT
https://github.com/mozilla/zamboni/commit/44b250a90c917a4419e99116ba55f6fe801e66e4

Settings in.

`geoip-geodude` is the waffle. I'll ping someone on IRC to enable it where appropriate.

Note You need to log in before you can comment on or make changes to this bug.