The default bug view has changed. See this FAQ.

Enable geo-location for marketplace

RESOLVED FIXED in 2013-04-18

Status

Marketplace
General
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: clouserw, Assigned: wraithan)

Tracking

2013-04-18
Points:
---

Details

(Reporter)

Description

4 years ago
Right now we determine what region you want to visit based on your language preferences.  We should do geo-location.

Apparently bug 774746 gave us geo-location, but I don't think those daemons were ever turned on.  CCing JR to give us the current status and we can pick up from there in this bug.
(Reporter)

Updated

4 years ago
Priority: -- → P1
(Reporter)

Updated

4 years ago
Assignee: nobody → xwraithanx
Updates:

mkelly has written a geoip server that is more inline with how we'd like to run, as well as being benchmarked: https://github.com/mozilla/geodude

It is currently deployed at http://geo.mozilla.org/country.json to see how it works.

Due to the dataset that we are using, we can't send an arbitrary IP to the server and get back data if the server is public. I'll be forking and adding an endpoint that handles this case. This means we'll need to deploy into our own infrastructure behind the firewall.

I've spoken to cvan to see where in zamboni we need this added, and I'll be coding that up as well as fixing the server. 

Current ETA for the server fork being ready is 2 hours, then I'll be working with ops to get it deployed on a dev server.

Current ETA for the zamboni side is 1-2 hours, it will be behind a waffle so it can be landed and tested on -dev but not affect release this week if we don't have production geoip servers yet.
(Reporter)

Comment 2

4 years ago
(In reply to Wraithan from comment #1)
> Due to the dataset that we are using, we can't send an arbitrary IP to the
> server and get back data if the server is public. I'll be forking and adding
> an endpoint that handles this case. This means we'll need to deploy into our
> own infrastructure behind the firewall.

Why would you fork instead of giving a patch to mkelly that has your endpoint behind a flag?
(Assignee)

Updated

4 years ago
Depends on: 854734
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2013-04-04
(Reporter)

Updated

4 years ago
Target Milestone: 2013-04-04 → ---
(Reporter)

Comment 3

4 years ago
What's happening with this bug?
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2013-04-11
(Reporter)

Updated

4 years ago
Target Milestone: 2013-04-11 → ---
https://github.com/mozilla/zamboni/commit/88656192eb05b560b04718422039df3cbfc6fac9

Code landed. waffle needs to be flipped and a setting added.
(Reporter)

Comment 5

4 years ago
(In reply to Wraithan from comment #4)
> https://github.com/mozilla/zamboni/commit/
> 88656192eb05b560b04718422039df3cbfc6fac9
> 
> Code landed. waffle needs to be flipped and a setting added.

what waffle?  what setting?
geoip-geodude is the waffle, the setting comment was more for me, I have a commit that adds them just waiting for r+, then I'll be done with this bug.
https://github.com/mozilla/zamboni/commit/44b250a90c917a4419e99116ba55f6fe801e66e4

Settings in.

`geoip-geodude` is the waffle. I'll ping someone on IRC to enable it where appropriate.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2013-04-18
You need to log in before you can comment on or make changes to this bug.