851418 - "Assertion failure: XPCJSRuntime::Get()->GetJSContextStack()->Peek() == cx"

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: XPCJSRuntime::Get()->GetJSContextStack()->Peek() == cx, at js/xpconnect/wrappers/WrapperFactory.cpp:346

bholley added this assertion in one of the patches in bug 834732,
http://hg.mozilla.org/mozilla-central/rev/a38bbae7a53b

Comment 1

[Jesse Ruderman]

Attachment: stack (gdb)

Comment 2

[Bobby Holley (:bholley)]

Attachment: Unscope the pusher in CompileEventHandlerInternal. v1

Comment 3

[Bobby Holley (:bholley)]

Attachment: Crashtest. v1 r=bholley

Comment 4

[Andrew McCreight [:mccr8]]

Sec high?

Comment 5

[Bobby Holley (:bholley)]

Given that bug 834732 has been marked sec-moderate, any bugs such as this one must be sec-moderate as well.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 725651 [details] [diff] [review]
Unscope the pusher in CompileEventHandlerInternal. v1

I don't actually know what are the new requirements for nsCxPusher and 
JSAutoRequest usage. Also, I don't know why you're changing the cx you give as a
parameter to JSAutoRequest.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 725651 [details] [diff] [review]
Unscope the pusher in CompileEventHandlerInternal. v1

It's a little weird to see us entering a request without entering a compartment, but given the lack of compartment mismatches, I'm assuming it's all right.

Olli, the patch here doesn't actually change which context we're passing anywhere, cx is set to context->GetNativeContext(); bholley just made it more explicit that we were passing the right context.

Comment 8

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f3efbbe97a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1f3efbbe97a

Comment 10

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df8c49b33b22

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df8c49b33b22