851492 - Needs a new unit test for the identity feature

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

Bug 839500 needs to have an additional unit test for the 'id-dialog-close-iframe' ChromeEvent.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Unit test for new identity signal, id-dialog-close-iframe

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

PR for v1-train: https://github.com/mozilla-b2g/gaia/pull/8683

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

PR for master: https://github.com/mozilla-b2g/gaia/pull/8688

Comment 4

[Ryan VanderMeulen [:RyanVM]]

John, can you merge this please?

Comment 5

[Julien Wajsberg [:julienw]]

a=npotb

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Jed Parsons [:jparsons] from comment #2)
> PR for v1-train: https://github.com/mozilla-b2g/gaia/pull/8683

Thanks for making the PR, but I don't see the necessary approval for this to land.  You should ask for approval-gaia-v1? on the bugzilla attachment to get that approval.


Master:
https://github.com/mozilla-b2g/gaia/commit/bf8bff25d573ed6ccd3966bf80be37097ebc8357

Comment 7

[Ryan VanderMeulen [:RyanVM]]

On the Gecko side, the usual policy is that test-only changes can land without explicit approval, but since this changes a non-test file as well, I agree that this should get approval for uplift.

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 725447 [details]
Unit test for new identity signal, id-dialog-close-iframe

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 839500 
User impact if declined: -
Testing completed: yes
Risk to taking this patch (and alternatives if risky): none; we're guarding against a non-existence of mozL10n, which doesn't happen on the device, but happens when unit testing in some conditions.
String or UUID changes made by this patch: none.

This is nearly a=npotb.

Comment 9

[Jason Smith [:jsmith]]

Jed - this is already fixed I think, right?

Comment 10

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

jsmith yup!

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit bf8bff25d573ed6ccd3966bf80be37097ebc8357 as:
v1-train: 81944f35ea07592d74690562eea20fc29e3e894d