Last Comment Bug 851527 - Strip null bytes in document titles when setting the chrome window's title.
: Strip null bytes in document titles when setting the chrome window's title.
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.19
Assigned To: Philip Chee
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-15 08:39 PDT by Philip Chee
Modified: 2013-03-16 01:51 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1.0 Proposed fix. (2.35 KB, patch)
2013-03-15 08:45 PDT, Philip Chee
neil: review+
Details | Diff | Splinter Review

Description Philip Chee 2013-03-15 08:39:57 PDT
See Firefox Bug 818014 and https://hg.mozilla.org/mozilla-central/rev/23d42f6e56b4
Comment 2 neil@parkwaycc.co.uk 2013-03-15 10:16:17 PDT
Comment on attachment 725422 [details] [diff] [review]
Patch v1.0 Proposed fix.

>+              docTitle = this.contentTitle.replace("\0", "", "g");
Nit: Please use the RegExp form /\0+/g instead.

>-              if (docElement.getAttribute("chromehidden").indexOf("location") != -1) {
>+              if (docElement.getAttribute("chromehidden").contains("location")) {
[Unless this is a stray leftover then these sorts of changes should be done in a dedicated bug.]
Comment 3 Philip Chee 2013-03-16 01:50:54 PDT
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/bf49737b12dc

> Nit: Please use the RegExp form /\0+/g instead.
Fixed.

> [Unless this is a stray leftover then these sorts of changes should be done in a dedicated bug.]
Removed.

Note You need to log in before you can comment on or make changes to this bug.