851527 - Strip null bytes in document titles when setting the chrome window's title.

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Philip Chee]

See Firefox Bug 818014 and https://hg.mozilla.org/mozilla-central/rev/23d42f6e56b4

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix.

Tested with Attachment 688971 [details] from Bug 818014
https://bug818014.bugzilla.mozilla.org/attachment.cgi?id=688971

Comment 2

[[e-mail]]

Comment on attachment 725422 [details] [diff] [review]
Patch v1.0 Proposed fix.

>+              docTitle = this.contentTitle.replace("\0", "", "g");
Nit: Please use the RegExp form /\0+/g instead.

>-              if (docElement.getAttribute("chromehidden").indexOf("location") != -1) {
>+              if (docElement.getAttribute("chromehidden").contains("location")) {
[Unless this is a stray leftover then these sorts of changes should be done in a dedicated bug.]

Comment 3

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/bf49737b12dc

> Nit: Please use the RegExp form /\0+/g instead.
Fixed.

> [Unless this is a stray leftover then these sorts of changes should be done in a dedicated bug.]
Removed.