The default bug view has changed. See this FAQ.

Strip null bytes in document titles when setting the chrome window's title.

RESOLVED FIXED in seamonkey2.19

Status

SeaMonkey
Tabbed Browser
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.19

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
See Firefox Bug 818014 and https://hg.mozilla.org/mozilla-central/rev/23d42f6e56b4
(Assignee)

Comment 1

4 years ago
Created attachment 725422 [details] [diff] [review]
Patch v1.0 Proposed fix.

Tested with Attachment 688971 [details] from Bug 818014
https://bug818014.bugzilla.mozilla.org/attachment.cgi?id=688971
Attachment #725422 - Flags: review?(neil)

Comment 2

4 years ago
Comment on attachment 725422 [details] [diff] [review]
Patch v1.0 Proposed fix.

>+              docTitle = this.contentTitle.replace("\0", "", "g");
Nit: Please use the RegExp form /\0+/g instead.

>-              if (docElement.getAttribute("chromehidden").indexOf("location") != -1) {
>+              if (docElement.getAttribute("chromehidden").contains("location")) {
[Unless this is a stray leftover then these sorts of changes should be done in a dedicated bug.]
Attachment #725422 - Flags: review?(neil) → review+
(Assignee)

Comment 3

4 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/bf49737b12dc

> Nit: Please use the RegExp form /\0+/g instead.
Fixed.

> [Unless this is a stray leftover then these sorts of changes should be done in a dedicated bug.]
Removed.
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.19
You need to log in before you can comment on or make changes to this bug.