851630 - Can't open popup notifications with the keyboard (focus gets stuck at the identity icon)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [:dao]]

STR:
1. focus the location bar
2. hit Shift+Tab (focuses the identity icon)
3. hit Shift+Tab again

expected result: focus moves on from the identity icon to the previous focusable icon (e.g. a popup notification anchor if present)

actual result: focus gets stuck at the identity icon

Comment 1

[Alex Keybl [:akeybl]]

In triage, we weren't able to repro on FF20, but 21 appears to be affected.

Comment 2

[u279076]

Last good nightly: 2013-02-11
First bad nightly: 2013-02-12

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5835bc763be7&tochange=36525224b14e

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Bholley: is this possible fallout from bug 839867?

Comment 4

[Bobby Holley (:bholley)]

(In reply to [e-mail] from comment #3)
> Bholley: is this possible fallout from bug 839867?

I doubt it, unless frontend code expects to be able to write location.hash cross-origin for some reason (which seems unlikely, because all that stuff should be System Principal).

Either way, I'm not the appropriate assignee for this bug until we're more sure of the nature of the platform regression, if any.

Comment 5

[Alex Keybl [:akeybl]]

Gavin, would you say initial investigation here falls on your team? We don't want to introduce a focus/a11y regression in FF21.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I bisected, this looks to have been caused by bug 758288, which is somewhat mysterious at first glance.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I guess http://hg.mozilla.org/mozilla-central/annotate/2949e808ed33/dom/src/events/nsJSEventListener.cpp#l254 treats undefined differently than "false", so that patch changed behavior.

Should we just switch this to a "return true"?

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Gavin can you take this on or re-assign if necessary? We'll need a speculative fix for this landed & verified before next Tuesday when we build 21.0b4.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Given the comment, I think this was just a mistake.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11336b456004

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 737729 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 758288
User impact if declined: as summarized
Testing completed (on m-c, etc.): tested manually
Risk to taking this patch (and alternatives if risky): no risk, just reverting an unintentional behavior change
String or IDL/UUID changes made by this patch: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11336b456004

Comment 13

[bhavana bajaj [:bajaj]]

Comment on attachment 737729 [details] [diff] [review]
patch

low risk patch,looks good to uplift. Requesting QA verification once this lands on branches.

Comment 14

[u279076]

Verified fixed in Firefox Nightly 23.0a1 2013-04-17. Added to queue for Firefox 21b4 sign-off.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d867a3dbe76
https://hg.mozilla.org/releases/mozilla-beta/rev/2fa233c8d280

Comment 17

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on FF 21 beta 4 (build ID: 20130423212553)

User agents:
Windows XP: Mozilla/5.0 (Windows NT 5.1; rv:21.0) Gecko/20100101 Firefox/21.0
Windows 7x64: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Ubuntu 12.04: Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0
Mac OSX 10.8: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Comment 18

[Manuela Muntean [Away]]

Verified fixed with Firefox 22 beta 1 (build ID: 20130514181517) on Mac OSX 10.7.5 and Ubuntu 12.10 32bit.