851661 - [B2G][Homscreen] User is unable to move app icons on the homescreen.

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[J Zimbrick]

Repro Steps:

1. Update Unagi device to build 20130315070220.
2. Unlock the phone and scroll one page to the right to access apps.
3. Long press one of the icons until it can be dragged around.
4. Attempt to move the app to a different location. (Move to a different row, change order on the same row, move to a different page, move to the bottom bar.)
5. Observe that the app icon will go back to where it came from originally, changes are not saved. The app can not be dragged to a different page or added to the bottom bar.

Actual Results:

User is unable to change where an icon is located.  Attempting to move the icon to a different location always reverts it to the original spot.  It can not be dragged to a different page or added to the bottom bar.

Expected Results:

The app can be moved wherever the user chooses.

Notes:

Found on an Unagi device running the following build:

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/78be5f74e410
Gaia: cd028015a499e4fc3a652d7aa6eb9f81a1ea8cd7
Build: 20130315070220

Comment 1

[Cristian Rodriguez (:crdlc)]

Please are you testing master, v1-train or v1.0.1? Thanks a lot

Comment 2

[Jason Smith [:jsmith]]

(In reply to crdlc from comment #1)
> Please are you testing master, v1-train or v1.0.1? Thanks a lot

b2g18, as shown in the notes.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to crdlc from comment #1)
> > Please are you testing master, v1-train or v1.0.1? Thanks a lot
> 
> b2g18, as shown in the notes.

Specifically, v1 train actually in terms of gaia. This is your run of the mill Nightly build.

Comment 4

[Cristian Rodriguez (:crdlc)]

Here is the regression

https://github.com/mozilla-b2g/gaia/commit/55b1765ca03eca9c6c32676844cb9acbb07bbb25#L0R1068

Comment 5

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 725617 [details]
Patch v1

IMHO I guess that if this bug 837062 would be on v1-train and v1.0.1 we wouldn't have this regression. Maybe the patch is not needed when bug 837062 will be uplifted

Comment 7

[Cristian Rodriguez (:crdlc)]

I cannot reproduce after uplifting this one

https://github.com/mozilla-b2g/gaia/commit/95d5b5125a81f14b985fd8b2d919718fb35e8933

Comment 8

[David Flanagan [:djf]]

Comment on attachment 725617 [details]
Patch v1

If I understand correctly, this bug is a regresssion on v1-train caused by an incorrect merge of an uplifted patch.  Is that right?

This patch deletes the pTapThreshold argument to init() at grid.js:1068.  But pTapThreshold is used at grid.js:1072, of the v1-train branch, so that line needs to be patched too.

So r-.

Comment 9

[Cristian Rodriguez (:crdlc)]

The patch was deleted because I uplifted this:

https://github.com/mozilla-b2g/gaia/commit/95d5b5125a81f14b985fd8b2d919718fb35e8933

There is not review :) There were a mistake with bug 837062 and now there are several bugs due to this. So I've just closed them like worksforme

Comment 10

[J Zimbrick]

Issue no longer seems to be occurring on an Unagi device running the following build:

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/24b27125d907
Gaia: b973e66f328d8e09e364654e17ddab9f2c938bc4
Build:  20130408075751

Icons can be moved around on the homescreen.

Verifying as works for me.