nsConentUtils: Don't dereference known-null pointer in nsContentUtils::CheckForSubFrameDrop
RESOLVED
FIXED
in mozilla22
Status
()
People
(Reporter: mark.yen, Assigned: mark.yen)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(URL)
Attachments
(1 attachment)
|
663 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Created attachment 725607 [details] [diff] [review] Don't dereference null target in nsContentUtils::CheckForSubFrameDrop See bug 605991 comment 34 - we're hitting a crash because the code is trying to read a null pointer. Attached patch fixes it to what it probably meant to be. (Asking smaug based on original review, since neil doesn't seem to be a peer in this area)
Attachment #725607 -
Flags: review?(bugs)
|
||
Comment 1•6 years ago
|
||
Comment on attachment 725607 [details] [diff] [review] Don't dereference null target in nsContentUtils::CheckForSubFrameDrop Just remove && !target->OwnerDoc() OwnerDoc() returns never null.
Attachment #725607 -
Flags: review?(bugs) → review+
|
(Assignee) | |
Comment 2•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d2b8487146c (... It's been a while since I pushed, hopefully I didn't screw up...)
|
||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9d2b8487146c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•