Closed Bug 851674 Opened 8 years ago Closed 8 years ago

nsConentUtils: Don't dereference known-null pointer in nsContentUtils::CheckForSubFrameDrop

Categories

(Core :: DOM: Drag & Drop, defect)

Product:
Core
Component:
DOM: Drag & Drop
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: mark.yen, Assigned: mark.yen)

References

(
URL
)

Details

Attachments

(1 file)

Don't dereference null target in nsContentUtils::CheckForSubFrameDrop
663 bytes, patch
smaug
: review+
Details | Diff | Splinter Review 
See bug 605991 comment 34 - we're hitting a crash because the code is trying to read a null pointer.  Attached patch fixes it to what it probably meant to be.

(Asking smaug based on original review, since neil doesn't seem to be a peer in this area)
Attachment #725607 - Flags: review?(bugs)
Comment on attachment 725607 [details] [diff] [review]
Don't dereference null target in nsContentUtils::CheckForSubFrameDrop

Just remove && !target->OwnerDoc()
OwnerDoc() returns never null.
Attachment #725607 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d2b8487146c
(... It's been a while since I pushed, hopefully I didn't screw up...)
https://hg.mozilla.org/mozilla-central/rev/9d2b8487146c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.