Closed Bug 851780 Opened 11 years ago Closed 11 years ago

Create a test_input_event.html test

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jwatt, Assigned: mounir)

Details

Attachments

(1 file, 2 obsolete files)

In bug 851090 I added 'input' event tests to test_change_event.html for <input type=range> because we don't seem to have 'input' event tests elsewhere, and because it seems to make sense to test 'input' and 'change' events together. We should either renaming test_change_event.html to test_change_and_input_events.html, or else split out the 'input' event tests into a separate file.

I prefer the former solution, and then going forwards we can add more 'input' tests to the file for other types.
Attached patch Patch (obsolete) — Splinter Review
Assignee: jwatt → mounir
Status: NEW → ASSIGNED
Attachment #730184 - Flags: review?(jwatt)
Summary: Consider renaming test_change_event.html to test_change_and_input_events.html, or split out 'input' event tests → Create a test_input_event.html test
Attached patch Patch (obsolete) — Splinter Review
Better if I remove the input event checks from test_change_event.html.
Attachment #730184 - Attachment is obsolete: true
Attachment #730184 - Flags: review?(jwatt)
Attachment #730187 - Flags: review?(jwatt)
Attachment #730187 - Flags: review?(jwatt) → review+
Attached patch PatchSplinter Review
Attachment #730187 - Attachment is obsolete: true
Attachment #730215 - Flags: checkin?
m-i is currently closed so marking as checkin-needed.
Keywords: checkin-needed
Attachment #730215 - Flags: checkin?
https://hg.mozilla.org/mozilla-central/rev/3c35d63085c0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: