851816 - "Copy Image" does not work in Private Browsing mode or when History is set to "Never remember history".

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[stevend811]

This was originally reported at https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1155934 by ullix.

In Firefox 19.0.2, when Private Browsing is started through Tools->Start Private Browsing or when Preferences->Privacy->History is set to "Never remember history", the "Copy Image" button in the right-click menu will not copy the selected image to the clipboard as it should. The contents of the clipboard if any remain unchanged.

The original reporter on Launchpad tested this in Ubuntu 10.04 and 12.04. In addition I tested it in Kubuntu 12.04 with both the package from Ubuntu's repository and the .tar.bz2 on Firefox's website. I was able to reproduce the bug in both cases. I also tested this in Windows 7 but it appeared to work as expected there.

Comment 1

[Matthias Versen [:Matti]]

The global private browsing mode got replaced by a per window private browsing mode.
Could you test a nightly build from mozilla.org ?

Comment 2

[(no longer active)]

This is not a regression and as far as I can tell, this has never worked properly on Linux.  The problem is that on Linux we have both the selection and the global clipboards, so nsClipboardPrivacyHandler::PrepareDataForClipboard gets called twice, and the second call to nsITransferable::AddDataFlavor fails since the NS_MOZ_DATA_FROM_PRIVATEBROWSING flavor already exists on the transferable, and then we bail out of the function and do not attempt to do anything further.

The reason that copying text works is that we don't attempt to set the selection clipboard data when you copy text, so the second AddDataFlavor call is never made.

Comment 3

[stevend811]

(In reply to Matthias Versen [:Matti] from comment #1)
> The global private browsing mode got replaced by a per window private
> browsing mode.
> Could you test a nightly build from mozilla.org ?

I tested it on the nightly build and the bug is occurring there as well.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[(no longer active)]

(In reply to stevend811 from comment #3)
> (In reply to Matthias Versen [:Matti] from comment #1)
> > The global private browsing mode got replaced by a per window private
> > browsing mode.
> > Could you test a nightly build from mozilla.org ?
> 
> I tested it on the nightly build and the bug is occurring there as well.

Yeah, this affects all versions of Firefox.

Comment 6

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f5bf6a0d04da

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f5bf6a0d04da