851828 - Type safety improvements for the profiler in Win64 builds

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 725795 [details] [diff] [review]
Patch (v1)

Review of attachment 725795 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/sps_sampler.h
@@ +472,5 @@
>      return mStackPointer == 0;
>    }
>    uint32_t stackSize() const
>    {
> +    return std::min(mStackPointer, mozilla::sig_safe_t(mozilla::ArrayLength(mStack)));

Why did you drop <uint32_t>? The return type is still that.

Comment 2

[Benoit Girard (:BenWa)]

Please rebase on top of bug 851748

Comment 3

[Benoit Girard (:BenWa)]

(In reply to Benoit Girard (:BenWa) from comment #2)
> Please rebase on top of bug 851748

Err I meant this should land on top of bug 851748, not that you have to do it. I can rebase+land this for you when I land bug 851748.

Comment 4

[(no longer active)]

(In reply to comment #3)
> (In reply to Benoit Girard (:BenWa) from comment #2)
> > Please rebase on top of bug 851748
> 
> Err I meant this should land on top of bug 851748, not that you have to do it.
> I can rebase+land this for you when I land bug 851748.

That would be great, thanks.

Comment 5

[(no longer active)]

(In reply to comment #1)
> Comment on attachment 725795 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=725795
> Patch (v1)
> 
> Review of attachment 725795 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: tools/profiler/sps_sampler.h
> @@ +472,5 @@
> >      return mStackPointer == 0;
> >    }
> >    uint32_t stackSize() const
> >    {
> > +    return std::min(mStackPointer, mozilla::sig_safe_t(mozilla::ArrayLength(mStack)));
> 
> Why did you drop <uint32_t>? The return type is still that.

unsigned long and uint32_t are interchangeable...  But I can add it back if you want.

Comment 6

[(no longer active)]

Not sure when bug 851748 will land...

Comment 7

[Benoit Girard (:BenWa)]

Going to try and land this today.

Comment 8

[Benoit Girard (:BenWa)]

Attachment: rebased

Comment 9

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a256c02fc6

Comment 10

[Benoit Girard (:BenWa)]

Backout for Mochitest failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ac624cfc84

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This ended up being a red-herring. Re-landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c5c83ed0385

Comment 12

[Benoit Girard (:BenWa)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)
> This ended up being a red-herring. Re-landed.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/0c5c83ed0385

Thank you :)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c5c83ed0385